[Awaiting Payment 3rd April] [$500] [Held requests] The last description in the Hold educational modal is truncated.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.43-2
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1708396292249669

Action Performed:

1. Create an IOU with other user
2. Go to the IOU details page
3. Click on top 3 dots and choose "hold request"
4. Type some reason and go to next page
5. observe the educational modal

Expected Result:

No truncation is seen

Actual Result:

Last description is truncated

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ce84146169d7114b
• Upwork Job ID: 1760015820653121536
• Last Price Increase: 2024-03-12
• Automatic offers:
• aimane-chnaif | Reviewer | 0
• Pujan92 | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ce84146169d7114b

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The last description in the Hold educational modal is truncated

What is the root cause of that problem?

This happens as we restrict the list to numberOfLines={3} in HoldMenuSectionList

App/src/components/HoldMenuSectionList.tsx

Lines 62 to 67 in 6b413b2

	<Text
	style={[styles.textNormal]}
	numberOfLines={3}
	>
	{translate(section.descriptionTranslationKey)}
	</Text>

What changes do you think we should make in order to solve the problem?

We should increase the numberOfLines to 4 so we can show all the lines without overextending.

<Text
    style={[styles.textNormal]}
    numberOfLines={4} 
>
    ...
</Text>

Result

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hold section description truncated

What is the root cause of that problem?

We set numberOfLines={3} for the hold menu section item here.

App/src/components/HoldMenuSectionList.tsx

Line 64 in e43a372

numberOfLines={3}

What changes do you think we should make in order to solve the problem?

Remove numberOfLines prop to allow it to show the full description.

[aneequeahmad]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Hold educational modal last description is truncated

What is the root cause of that problem?

numberOfLines={3} defined in HoldMenuSectionList.tsx is causing truncation.

What changes do you think we should make in order to solve the problem?

if we remove the this piece of code numberOfLines={3} without checking the platform then it would look weird on smaller devices.
If the platform is Web we shouldn't truncate. We can add a condition to check if the platform is web numberOfLines={isWeb ? undefined : 3}.

What alternative solutions did you explore? (Optional)

N/A

[aimane-chnaif]

Thanks for the proposals everyone.

it would look weird on smaller devices.

@aneequeahmad can you please share screenshot for this case?