[Violations] [$1000] Violations are not shown as approver

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.41-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1707848268463619

Action Performed:

1. Go to OldDot staging.expensify.com and open or create a Collect policy
2. Make tags required for the policy

• Go to Settings > [Workspace] > Tags
• Enable "People must tag expenses"
• Add a tag

3. Set violations for category as to be required
4. Go to the policy page
5. In the JS console with the policy open do:

p = Policy.getCurrent();
p.policy.isPolicyExpenseChatEnabled = "true";
p.save();

6. Invite a user to the policy as employee
7. As an employee sign in to the NewDot, create a expense report without category and tag set
8. Open the report as approver logged in to NewDot

Expected Result:

Error message for violations are shown

Actual Result:

Not seeing violations as approver

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ebca0f5b1a041068
• Upwork Job ID: 1757526242287419392
• Last Price Increase: 2024-02-22

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ebca0f5b1a041068

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[brandonhenry]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Approvers are not seeing the expected error messages for violation of expense report policies, specifically when category and tag settings are required but not set by the employee on the report.

What is the root cause of that problem?

The root cause may involve the policy enforcement logic within the approver's view. It appears the validation checks that trigger error messages for missing categories or tags are not executing correctly, or the UI is not displaying the results of these checks as it should.

What changes do you think we should make in order to solve the problem?

• Review the expense report validation flow to ensure that the checks for required fields are triggered when an approver reviews a report.
• Update the UI components responsible for displaying the error messages to approvers to ensure they are activated correctly when violations are detected.
• Ensure that the state management for the report correctly reflects the presence of violations and binds this state to the UI elements for error message display.
• Conduct tests on all supported platforms to ensure that upon opening a report with set violations, the approver is presented with the appropriate error messages.

What alternative solutions did you explore? (Optional)

• An alternative solution could be to implement a pre-approval validation step, prompting the employee to correct the violations before submission to the approver. However, this may not be desirable as it shifts the responsibility from the approver to the employee.

[bfitzexpensify]

@cead22 is this something you're planning on working on yourself, or is this something that contributors can tackle?