Request money - Endless loading spinner when requesting money from phone number account

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Lunch the expensify cash app
2. Sign-up to Expensify.cash with a US phone number and validate that account (Account A)
3. Create another account with a different US phone number (Account B)
4. Log in with Account A
5. Click on green button
6. Click Request Money
7. Enter the phone number you like to request money
8. Click Next

Expected Result:

Able to request money from phone number account

Actual Result:

Endless loading spinner appears and could not complete the request

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web ✔️
iOS ✔️
Android ✔️
Desktop App ✔️
Mobile Web ✔️

Version Number: 1.0.69-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5115873_Screen_Recording_20210616-110357_Expensifycash.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Santhosh-Sellavel]

Duplicate of #3572

[isagoico]

Mm not sure if the same issue. This is happening with phone number accounts.

[Beamanator]

Some logs related to the fail:

2021-06-17T11:35:03.441570+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?api? [info] ACHTUNG debug mode is ON
2021-06-17T11:35:03.442067+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?api? [info] PID ~~ 882
2021-06-17T11:35:03.443683+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?api? [info] [10.2.2.1->/api.php] Malformed REQUEST: 'reportID' = 'NaN', ignoring (should match '-?\d+').
2021-06-17T11:35:03.443762+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?api? [info] [10.2.2.1->/api.php] Malformed REQUEST: 'reportActionsOffset' = '-1', ignoring (should match '\d{1,10}').
2021-06-17T11:35:03.444628+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [info] Processing 'Report_GetHistory' for 'expensify.com' from '156.213.242.194'  ~~ accountID: '37' authToken: '<REDACTED>' email: '+201092439511@expensify.sms' command: 'Report_GetHistory' reportActionsLimit: '50' referer: 'ecash' api_setCookie: 'false' browserGUID: '60cb33676c7b2' partnerName: 'expensify.com'
2021-06-17T11:35:03.444678+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [dbug] _send( expensidev2004.web.api.command.Report_GetHistory:1|c )
2021-06-17T11:35:03.444862+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [info] Get Report 0 from store
2021-06-17T11:35:03.445041+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [info] ReportStore::getByID() - not found ~~ reportID: 'i:0;' reqReportID: '(n/a)' reqReportIDList: '(n/a)' command: 'Report_GetHistory'
2021-06-17T11:35:03.445232+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [alrt] [OOPS!] API threw  InvalidArgumentException - 8ad63b5a7be1427567f0d6b553acad53 ~~ exceptionMessage: 'Invalid ReportID '0' for the report store' exceptionFile: '/vagrant/Web-Expensify/lib/ReportStore.php' exceptionLine: '119' exceptionCode: '402'
2021-06-17T11:35:03.445284+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [dbug] _send( expensidev2004.web.log.alert:1|c )
2021-06-17T11:35:03.449953+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [info] DB_Analytics - Connecting to database. ~~ attemptNumber: '1' host: '127.0.0.1' dbName: 'analytics'
2021-06-17T11:35:03.450493+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [info] [benchmark] Stop timing 'DB Connect DB_Analytics' (took 0.0006 seconds)
2021-06-17T11:35:03.450553+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [dbug] DB_Analytics - INSERT INTO serverErrors( created, uuid, message, email, accountID, requestID, source ) VALUES( '2021-06-17 11:35:03', 'ALRT_91dc7f57eb30e1de4077445d67ec0bec', '[OOPS!] API threw  InvalidArgumentException - 8ad63b5a7be1427567f0d6b553acad53', '+201092439511@expensify.sms', 37, '0iV8Uc', 'api' );
2021-06-17T11:35:03.451054+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [info] Benchmark started:DB_Analytics - Executing query
2021-06-17T11:35:03.452324+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [info] Benchmark finished:DB_Analytics - Executing query ~~ time: '0.0016961097717285'
2021-06-17T11:35:03.455164+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [info] [push] Push_Service - Push_Service sending event ~~ channel: '[0: 'public-debugserverid604a3ae1b9945']' eventName: 'debug' eventData: '{"level":"alert","message":"[OOPS!] API threw  InvalidArgumentException - 8ad63b5a7be1427567f0d6b553acad53 ~~ exceptionMessage: 'Invalid ReportID '0' for the report store' exceptionFile: '\/vagrant\/Web-Expensify\/lib\/ReportStore.php' exceptionLine: '119' exceptionCode: '402'"}'
2021-06-17T11:35:04.138446+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [info] [trace] StackTrace start
2021-06-17T11:35:04.138782+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [info] [trace] 0/0. file '/vagrant/Web-Expensify/api.php' function 'getByID' line '575'
2021-06-17T11:35:04.139022+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [info] [trace] StackTrace end
2021-06-17T11:35:04.139125+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [info] StoreUtils - Clearing all the stores.
2021-06-17T11:35:04.139255+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [info] TransactionStore cache fully cleared
2021-06-17T11:35:04.139380+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [info] ReportStore cache cleared
2021-06-17T11:35:04.139438+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [info] NVPStore - clear cache
2021-06-17T11:35:04.139596+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [info] NVPStore - clear cache
2021-06-17T11:35:04.139655+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [info] SharedInNVPStore - clear cache
2021-06-17T11:35:04.139733+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [info] ReportDuplicatedTransactionsStore - Cache cleared
2021-06-17T11:35:04.139862+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [dbug] _send( expensidev2004.web.api.result.error.402:1|c )
2021-06-17T11:35:04.139939+00:00 expensidev2004 php-fpm: Xdebug: [Step Debug] Could not connect to debugging client. Tried: 10.0.2.2:9000 (through xdebug.client_host/xdebug.client_port) :-(
2021-06-17T11:35:04.140436+00:00 expensidev2004 php-fpm: 0iV8Uc /api.php +201092439511@expensify.sms !ecash! ?report? [info] Profile ~~ {"total":700,"cmd":"Report_GetHistory","jsonCode":402,"output":{"size":104,"gzip":1,"ratio":114},"gzip":104,"PHP":{"total":698,"%":99,"boot":3,"proc":695,"pack":0,"mem":2}}

-> Looks like we passed reportID: 'NaN' to Report_GetHistory from e.cash and didn't happily handle a failed response

[Beamanator]

Report_GetHistory is only called by fetchActions.

fetchActions is only called in ReportActionsView in componentDidMount, where this.props.reportID is null

• Confirmed with [info] [ReportActionsView] component did mount ~~ parameter: '{"reportID":null}'

ReportActionsView is rendered by ReportView (reportID passed down directly), which is rendered by ReportScreen

• reportID passed by this.getReportID(), which gets the ID from this.props.route.params.reportID
• Confirmed with log [info] [ReportScreen] getReportID ~~ parameter: '{"params":{"reportID":"undefined"}}'

Looks like this is where the problem is:

2021-06-17T12:24:00.824458+00:00 expensidev2004 php-fpm: hzK4xx /api.php +201092439511@expensify.sms !ecash! ?api? [info] [10.2.2.1->/api.php] Malformed REQUEST: 'debtorEmail' = '+201092439513', ignoring (should match '(?:DELETED_\d@)*[\w\.'#%+-]+@[a-zA-Z\d\.-]+\.[a-zA-Z]{2,}').
2021-06-17T12:24:00.825150+00:00 expensidev2004 php-fpm: Xdebug: [Step Debug] Could not connect to debugging client. Tried: 10.0.2.2:9000 (through xdebug.client_host/xdebug.client_port) :-(
2021-06-17T12:24:00.826409+00:00 expensidev2004 php-fpm: hzK4xx /api.php +201092439511@expensify.sms !ecash! ?api? [info] Processing 'CreateIOUTransaction' for 'expensify.com' from '156.213.242.194'  ~~ accountID: '37' authToken: '<REDACTED>' email: '+201092439511@expensify.sms' command: 'CreateIOUTransaction' comment: 'Iou' amount: '500' currency: 'EGP' referer: 'ecash' api_setCookie: 'false' browserGUID: '60cb3ee0c9901' partnerName: 'expensify.com'
2021-06-17T12:24:00.826528+00:00 expensidev2004 php-fpm: hzK4xx /api.php +201092439511@expensify.sms !ecash! ?api? [dbug] _send( expensidev2004.web.api.command.CreateIOUTransaction:1|c )

We're expecting debtorEmail to be in the format (?:DELETED_\d@)*[\w\.'#%+-]+@[a-zA-Z\d\.-]+\.[a-zA-Z]{2,}, but we're inputting a phone number format.

This should be fixable by allowing phone numbers as well - will test soon

• Fixed locally, we can just add the domain to the phone number so it acts like an email address
• Need to make sure it works in Auth commands too

[Beamanator]

Ok what I'd prefer is fixing this in E.Cash, then making sure error handling is working well so here's what I'm planning:

• Make sure phone number searches create phone number domains in OptionsListUtils
  • Add @expensify.sms to the end, if it's not there already
• Make a new expensify-common function to add @expensify.sms to a phone number

In future (separate issue), maybe we should handle API errors more gracefully in e.cash - not just letting a spinner spin forever

[Beamanator]

In OptionsListUtils it looks like this creates a login without an @expensify.sms domain (just whatever the user types - as long as it's a phone number), which gets passed into userInvitePersonalDetails, which passes to userToInvite, which gets used in IOUParticipantsSplit and IOUParticipantsRequest in a new section (data: [this.state.userToInvite]) which both call onAddParticipants with the selected option, which sets them in state &...

• For creating a request, the login is grabbed & passed to createIOUTransaction
• For creating a split, the logins are mapped to emails and passed along to CreateChatReport, which in the backend, converts phone number logins to SMS emails

It looks like we have enough places where we're doing Str.removeSMSDomain to get rid of SMS domains in a login, so it should be fine to force login to be an SMS domain (if it's a phone number)