[HOLD for payment 2024-02-20] Request - App asks for location access when creating Manual request with receipt

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4-38.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

• App location permission is reset

1. Launch New Expensify app
2. Go to workspace chat
3. Go to FAB > Request money > Manual
4. Proceed to confirmation page
5. Add a receipt
6. Tap Request

Expected Result:

App will not ask for location access since Manual request is created. No smartscanning is involved

Actual Result:

App asks for location access when creating manual request with receipt

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6370479_1707318572511.Screen_Recording_20240207_212146_Permission_controller__1___1_.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @JmillsExpensify

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #wave5
CC @dylanexpensify

[AndrewGable]

@tgolen is this expected with #35428 ? Should we not grab GPS when it's a manual expense?

[tgolen]

I guess it's not expected, no. I can add some logic to bypass the GPS if there is a transaction.amount. That should cover the manual expense case. I don't think this is a deploy blocker though.