[$500] Workspace - The default room opening after creating a workspace is #announce

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.36.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4278685&group_by=cases:section_id&group_id=229065&group_order=asc
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.chat.expensify.com
2. Click on the "Choose a workspace" button and click on the + button next to "Workspaces" to create a new one
3. Navigate to "Chats" by using the bottom nav

Expected Result:

It should be #admins

Actual Result:

The default room opening after creating a workspace is #announce

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6366317_1706995675650.bandicam_2024-02-02_18-15-30-499.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010c52a7ad4ac358f7
• Upwork Job ID: 1754503277690073088
• Last Price Increase: 2024-02-05

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #wave6
CC @greg-schroeder

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The default room opening after creating a workspace is #announce

What is the root cause of that problem?

1. We only find the admin room if openOnAdminRoom is true

App/src/libs/ReportUtils.ts

Lines 1025 to 1026 in 0ae07be

	if (openOnAdminRoom) {
	adminReport = sortedReports.find((report) => {

2. We don't update isFirstTimeNewExpensifyUser in Onyx to true when we show engagement modal

App/src/libs/actions/Welcome.ts

Line 176 in 0ae07be

isFirstTimeNewExpensifyUser = false;

App/src/libs/actions/Welcome.ts

Line 164 in 0ae07be

isFirstTimeNewExpensifyUser = false;

And then we return the first report in the sorted report list by lastRead that is not concierge chat

App/src/libs/ReportUtils.ts

Line 1046 in 0ae07be

return adminReport ?? sortedReports.find((report) => !isConciergeChatReport(report)) ?? null;

3. When we create optimistic data for new workspace, announce report is created first so the first report in the sorted report list is the announce report.

App/src/libs/ReportUtils.ts

Line 3461 in 0ae07be

const announceCreatedAction = buildOptimisticCreatedReportAction(CONST.POLICY.OWNER_EMAIL_FAKE);

That is the root cause of this issue

What changes do you think we should make in order to solve the problem?

1. We should update isFirstTimeNewExpensifyUser in Onyx to true instead of setting isFirstTimeNewExpensifyUser variable to false

App/src/libs/actions/Welcome.ts

Line 176 in 0ae07be

isFirstTimeNewExpensifyUser = false;

App/src/libs/actions/Welcome.ts

Line 164 in 0ae07be

isFirstTimeNewExpensifyUser = false;

2. When we create optimistic data for new workspace, we should config the lastReadTime of announce, admin, and policyExpense report to make the last read time of admin room is biggest

App/src/libs/ReportUtils.ts

Line 3461 in 0ae07be

const announceCreatedAction = buildOptimisticCreatedReportAction(CONST.POLICY.OWNER_EMAIL_FAKE);

What alternative solutions did you explore? (Optional)

We can always get adminReport in findLastAccessedReport and only not report it if it doesn't exist.