[$500] Workspace - WS name and avatar not updated after changing name in settings

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.35
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: exploratory around #35214
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open the app and log in
2. Create a workspace
3. Navigate to the workspace chat and request money
4. Tap the WS name above the expense preview or in the header
5. Tap "Workspace" > name of the WS
6. Change the name to something else
7. Go back to the Workspace chat

Expected Result:

The new workspace name is displayed above the expense preview

Actual Result:

The workspace is not updated, user has to return LHN and then open the WS chat or open the expense and go back to see the updated name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6364006_1706816897597.IMG_5031.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01789739c6d7bf62f5
• Upwork Job ID: 1753152667767562240
• Last Price Increase: 2024-02-01

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01789739c6d7bf62f5

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

WS name and avatar not updated after changing name in settings

What is the root cause of that problem?

We haven't considered policyName when memoizing ReportActionItem

App/src/pages/home/report/ReportActionItem.js

Lines 844 to 845 in 9d4c634

	prevProps.report.reportName === nextProps.report.reportName &&
	prevProps.report.description === nextProps.report.description &&

What changes do you think we should make in order to solve the problem?

We need to re-render onpolicyName change so we need to consider it on the memoizing

            prevProps.report.policyName === nextProps.report.policyName &&

What alternative solutions did you explore? (Optional)

[Santhosh-Sellavel]

Unable to reproduce this on dev

[zanyrenney]

Can't repro either, i expect we fixed this in the Ideal Nav launch. Closing.