[HOLD for payment 2024-02-15] [$500] Wallet - Input in Activate card page has BNP and also allows device keypad

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.34-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #35303

Action Performed:

1. Log in with account that has Expensify card (virtual) (applausetester@applause.expensifail.com
   ).
2. Go to Settings > Wallet.
3. Tap Expensify card.
4. Tap Activate physical card.
   Note that

Expected Result:

The page will either show BNP and disable device keypad input, or disable BNP and allow device keypad input

Actual Result:

The page shows BNP and the digit input also allows device keypad at the same time

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6362455_1706713671288.Screen_Recording_20240131_221648_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019ec1c0f677740061
• Upwork Job ID: 1752714526879559680
• Last Price Increase: 2024-01-31
• Automatic offers:
• getusha | Reviewer | 28137110
• bernhardoj | Contributor | 28137111

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019ec1c0f677740061

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[lanitochka17]

We think that this bug might be related to #wave.
CC @dylanexpensify

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A keyboard is shown alongside with the big number pad on the activate card page.

What is the root cause of that problem?

We didn't disable the keyboard to show. We pass a isDisableKeyboard props to the magic code input,

App/src/pages/settings/Wallet/ActivatePhysicalCardPage.js

Lines 144 to 145 in d0e8e2a

	<MagicCodeInput
	isDisableKeyboard

but we didn't disable the keyboard when isDisableKeyboard is true.

What changes do you think we should make in order to solve the problem?

We need to disable the keyboard when isDisableKeyboard is true.

App/src/components/MagicCodeInput.tsx

Lines 368 to 369 in d0e8e2a

	<TextInput
	onLayout={(e) => {

disableKeyboard={isDisableKeyboard}

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

BNP is shown in the activate card page

What is the root cause of that problem?

we disable keyboard in the activate card apge

App/src/pages/settings/Wallet/ActivatePhysicalCardPage.js

Line 145 in 9208c95

isDisableKeyboard

What changes do you think we should make in order to solve the problem?

remove the prev prop as we do in other MagicCodeInput instances so that we have a consistent view

[getusha]

@bernhardoj looks like we don't have this issue on SignIn page is there any reason behind that? and looks like the prop was intentionally avoided to pass as disableKeyboard 4bf0243#diff-ecae0b82a8a72087e4f45a15da40053c9b9addf7e830c5ba2975f24956bb9eaaR142