[HOLD for payment 2024-02-20] [$500] Task - The assignee ">" arrow is not grayed out when creating tasks offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.32-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open a chat
2. Navigate to offline mode
3. Go to the assign task, enter the title, and complete the flow
4. Click on the task and hover over the assignee

Expected Result:

The Assignee and arrow should be grayed out when creating tasks offline

Actual Result:

The assignee ">" arrow is not grayed out when creating tasks offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6355164_1706218851535.2024-01-26_01-22-50.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c0e46b804f5e69b6
• Upwork Job ID: 1750639313882955776
• Last Price Increase: 2024-01-25
• Automatic offers:
• fedirjh | Reviewer | 28124121
• neonbhai | Contributor | 28124123

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c0e46b804f5e69b6

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task - The assignee ">" arrow is not grayed out when creating tasks offline

What is the root cause of that problem?

The assignee MenuItem here is not wrapped in OfflineWithFeedback

What changes do you think we should make in order to solve the problem?


We should wrap the MenuItem here with the outer OfflineWithFeedback defined here:

App/src/components/ReportActionItem/TaskView.js

Line 163 in 8cc80e6

<OfflineWithFeedback pendingAction={lodashGet(props, 'report.pendingFields.managerID')}>


<OfflineWithFeedback pendingAction={lodashGet(props, 'report.pendingFields.managerID')}>

   {props.report.managerID ? (

     <MenuItem

         ...

     /> 
   ) : (

     <MenuItemWithTopDescription

         ...

     /> 

</OfflineWithFeedback>

[fedirjh]

@neonbhai we have report.pendingFields.managerID , managerID is the assignee

[neonbhai]

ah right, thanks!

[fedirjh]

Looks good, let's wrap both menu items with the same OfflineWithFeedback.