[$500] Android – Attachment – App flickering when uploading a long image to a conversation

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.30-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open New Expensify app
2. Log in with the account
3. Open any chat
4. On a conversation, click on the + button in the compose box
5. Upload long image to a conversation

Expected Result:

Preview of the image is displayed before uploading to the conversation

Actual Result:

App flickering when uploading a long image to a conversation in preview. Flashes on first boot

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6352453_1706038657902.App_flickering_when_uploading_a_long_image.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011d877180b69b96f5
• Upwork Job ID: 1749885428346445824
• Last Price Increase: 2024-01-30
• Automatic offers:
• jjcoffee | Reviewer | 28132224
• ZhenjaHorbach | Contributor | 28132225

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011d877180b69b96f5

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android – Attachment – App flickering when uploading a long image to a conversation

What is the root cause of that problem?

The main problem with the issue is that when we load a long photo we call onLoad a few times ( But according to the documentation, onLoad should only call once, which means the image is completely loaded )

App/src/components/Lightbox.js

Lines 185 to 189 in 6cfdd6f

	onLoad={(e) => {
	const width = (e.nativeEvent?.width || 0) * PixelRatio.get();
	const height = (e.nativeEvent?.height || 0) * PixelRatio.get();
	setImageDimensions({...imageDimensions, lightboxSize: {width, height}});
	}}

What changes do you think we should make in order to solve the problem?

To fix this issue we can update the code and add new condition which will prevent unnecessary onLoad calls. For this we can use isLightboxLoaded

                                    onLoad={(e) => {
                                        if (isLightboxLoaded) {
                                            return;
                                        }

                                        const width = (e.nativeEvent?.width || 0) * PixelRatio.get();
                                        const height = (e.nativeEvent?.height || 0) * PixelRatio.get();
                                        setImageDimensions({...imageDimensions, lightboxSize: {width, height}});
                                    }}

What alternative solutions did you explore? (Optional)

NA

[jjcoffee]

Reviewing tomorrow!

[jjcoffee]

@ZhenjaHorbach Thanks for the proposal! The RCA feels a bit underdeveloped; I'm curious why onLoad is being called multiple times if it's only supposed to be called once. I also wonder if this is device specific?

@lanitochka17 Could you update/add which platforms this affects?