[HOLD for payment 2024-02-12] [$500] Chat - Selected user doesn't move to top of list when searched & select from contacts list

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.30-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com & log in
2. Click FAB button >> Select Start Chat
3. Click on name, email or phone number search field
4. Search & click on Add to group button from Contact's list

Expected Result:

Selected user should move to top of list on tapping add to group button from contacts list

Actual Result:

Selected user doesn't move to top of list when searched & select users from contacts list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6352430_1706037847647.Recording__8.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01817102b5066cf873
• Upwork Job ID: 1749881133288943616
• Last Price Increase: 2024-01-23
• Automatic offers:
• akinwale | Reviewer | 28125015
• dukenv0307 | Contributor | 28125016

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01817102b5066cf873

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Chat - Selected user doesn't move to top of list when searched & select from contacts list

What is the root cause of that problem?

• We use formatSectionsFromSearchTerm to get the top of list (selected options). In this case, it returns {} because the below condition:
  

  App/src/libs/OptionsListUtils.js

  Line 1973 in 3122efa

  return isPartOfSearchTerm && !isReportInRecentReports && !isReportInPersonalDetails;

  
  will return false. We do it to make sure:
  

  App/src/libs/OptionsListUtils.js

  Lines 1966 to 1967 in 3122efa

  	// If you select a new user you don't have a contact for, they won't get returned as part of a recent report or personal details
  	// This will add them to the list of options, deduping them if they already exist in the other lists

What changes do you think we should make in order to solve the problem?

• Just need to call OptionsListUtils.getFilteredOptions in NewChatPage with param includeSelectedOptions is false

What alternative solutions did you explore? (Optional)

• NA

[dukenv0307]

@akinwale What do you think about my proposal?

[akinwale]

We can move forward with @dukenv0307's proposal here.

🎀👀🎀 C+ reviewed.