Web - "Failed to delete contact method" appears when user remove contact method

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.27.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #34125

Action Performed:

1. On staging, enable "Simulate failing network requests" in Settings > Preferences
2. Go to Settings > Profile > Contact method
3. Add a phone number as a new contact method
4. Wait for the pending add operation to fail
5. Once you see the red dot, click on the contact method and clear the error
6. Wait for a while - red dot reappears with new message that user cannot delete contact method

Expected Result:

The red dot should disappear after the error is cleared and no other error message should appear

Actual Result:

After a while - "Failed to delete contact method" message appears when user remove the phone number contact method

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6346885_1705603580974.Recording__1843.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dangrous]

Isn't this just because we are simulating failing network requests, and deleting the contact method is also a network request?

[dangrous]

I also am unable to reproduce, unless it takes a VERY long time for the second error to show up. I'll ask if anyone else can.

EDIT: It happened!

[dangrous]

@danieldoglas can you take a look at this, coming from #34125 ? I'm still trying to trace back why this is happening (it's also showing both errors, which I think is particularly incorrect), but wanted to ping right away

[dangrous]

I think this might be intended behavior, though I'm not entirely clear on why. Like, that deletion error is being sent back appropriately from Auth - it's this line, just with It belongs to accountID: 0 because it doesn't exist at all. My only confusion is whether or not we should be able to see BOTH errors ever, which I would think no?

[dangrous]

Here are more specific questions, for those investigating:

• The “bug” is that when you click “Remove” on a contact method you just unsuccessfully added, it then calls DeleteContactMethod which, in turn, fails because the contact method was never actually added. This seems bad, but seems intentional based on the code that is there now (both on the front end and in Auth). Maybe it’s just an edge case though, and we should update the front end to just visually remove rather than sending the request to the backend. This is my preferred suggestion, as of now.
• The reproduction steps include turning on “simulate failing network requests” but at least on dev my requests are indeed going to the backend. Why? Does it still send them, it just pretends it doesn’t? I’m not sure that affects the bug, but I’m still confused.
• A second part to this ^ - as noted in a previous comment, shouldn't the DeleteContactMethod request throw an error no matter what since we have simulated failures? Why doesn't that - or the initial request - go red immediately?
• When the second error shows up, it shows the first one again. This seems incorrect, but I'm not clear on why it's happening. This may be the only thing that's actually related to [HOLD for payment 2024-01-26] [$500] Settings - Red dot remains after error is cleared #33021, though I'm not sure. Is this fine, though, since if we fix the removing of the nonexistent contact method, we'll never see this screen?

All in all I'm sort of confused as to which part of this is the actual bug. Hopefully those thoughts help!

[mountiny]

cc @tienifr @ntdiary to confirm this behaviour

I dont think this has to be blocker as it does not seem worse than before