[HOLD for payment 2024-02-05] [HOLD for payment 2024-01-28] [HOLD for payment 2024-01-26] Request money - Contact selection list in Request money page is missing user avatars

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.27-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to FAB > Request money > Manual
2. Enter amount > Next

Expected Result:

User avatar will appear next to the contact

Actual Result:

User avatar is missing. The same issue also occurs in Room member list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6346415_1705579565516.bandicam_2024-01-18_16-30-47-166__1_.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[lanitochka17]

#wave6-collect-subt-mitters

[situchan]

confirmed regression from #34008

[situchan]

cc: @filip-solecki

[Julesssss]

Can reproduce. Found the PR

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Contact selection list in Request money page is missing user avatars

What is the root cause of that problem?

It is a regression from this PR
#34008

where the condition changed to item.rightElement === undefined instead of checking the icons lenght

App/src/components/SelectionList/BaseListItem.tsx

Lines 32 to 33 in c9970e4

	const isRadioItem = item.rightElement === undefined;

What changes do you think we should make in order to solve the problem?

change this line to as it was before

    const isRadioItem = !item?.icons?.length > 0;

or better would be to change it to

    const isListItem = item?.icons?.length > 0;

and revert the condition here