[HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Request money - System message shows negative amount briefly when paying request

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.26-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. [User A] Request money from User B
2. [User B] Navigate to chat with User A
3. [User B] Click on the preview to go to IOU report
4. [User B] Click Pay elsewhere

Expected Result:

The system message shows the correct amount

Actual Result:

The system message shows negative amount briefly

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6345825_1705526401046.-1068207674234802113bandicam_2024-01-18_02-08-54-906.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[lanitochka17]

#wave6-collect-submitters

[neil-marcellini]

Taking a look now 👀

[neil-marcellini]

This is a very minor problem, but a new problem nonetheless. None of the PRs we deployed recently stand out to me, so I'll debug it and see if I can figure out what's causing the problem.

[neil-marcellini]

I tested this offline so I can inspect the optimistic data. It looks like the html message is right but the iouMessage is wrong.

[neil-marcellini]

Asked for feedback on whether we should revert (again again) in Slack here