[$500] Chat - Infinite loading occurs after enabling the internet

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.25-4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Log in with 2 separate accounts in the main testing device and a secondary device
2. Disable the internet connection in the main testing device
3. From the main + menu, create a money request with the account logged in the secondary device
4. In the secondary device request money to the main testing device account
5. Enable the internet connection in in the main testing device, the money request request will be sent and will get a response an error.
6. Verify that the chat row in the LHN appears greyed out with a solid red dot icon
7. Click into the chat that failed to create that have a red dot
8. Verify you see an error message in-line beneath the welcome message because it failed to be created.
9. Tap/click the X on the Report no longer exists error to dismiss the error message
10. Verify the chat is deleted and removed from the LHN
11. Verify you are routed to your chat with Concierge

Expected Result:

After enabled the internet connection in in the main testing device, the money request request will be sent and will get a response an error.

Actual Result:

Infinite loading occurs after enabling the internet

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6344248_1705408428309.2024-01-16_02-38-32.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0115b2b43553abb055
• Upwork Job ID: 1747315684569538560
• Last Price Increase: 2024-02-06
• Automatic offers:
• aimane-chnaif | Contributor | 28124444

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[arosiclair]

Attempting to reproduce on prod...

Works correctly on prod v1.4.24-8. Note that this scenario only occurs when there is no pre-existing chat. If there is a pre-existing chat, the offline money request should succeed without issue.

[arosiclair]

Reproduced in staging v1.4.25-7

[arosiclair]

Nothing obvious is jumping out to me in the deploy's PR list or diff. This may be a backend issue

[arosiclair]

Okay it seems the RequestMoney command fails and correctly sets the error for the report already existing. However, the following OpenReport command clears the report by setting it to null. This triggers the loading view since isReportReadyForDisplay would evaluate to false here.

It seems that the OpenReport call is coming from the ReportActionsView here. Calling OpenReport there seems unnecessary since it's already handled in the ReportScreen. I think we should probably get rid of it, but I'm not sure.

[arosiclair]

Can't find anything in the current deploy that might have caused this. This is also an edge case so I don't think this needs to be a blocker so removing the label