[HOLD for payment 2024-02-15] [$500] Bank Account - On Test transactions page, invalid amount error displayed when value is less than 0.005

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.25-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Pre-requisite: user should be logged in and have created a workspace.

1. Go to Settings > Workspaces > Select a workspace > Bank account.
2. Select the Manual method to add a bank account.
3. Go trough the add back account flow until you reach the Test transactions page.
4. Try to enter a value less than 0.005 in the value fields.

Expected Result:

The user should be able to enter any value amount.

Actual Result:

The user can not enter values less than 0.005.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6343502_1705350056901.bandicam_2024-01-15_14-04-56-830.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014e3048efb731d9bc
• Upwork Job ID: 1746999099054366720
• Last Price Increase: 2024-01-22
• Automatic offers:
• akinwale | Reviewer | 28121605
• tienifr | Contributor | 28121606

Issue Owner

Current Issue Owner: @kevinksullivan

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014e3048efb731d9bc

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On the Test Transaction page, invalid amount error is displayed when the value is less than 0.005

What is the root cause of that problem?

In /src/pages/ReimbursementAccount/ValidationStep.js:

App/src/pages/ReimbursementAccount/ValidationStep.js

Lines 63 to 67 in b195e00

	const filterInput = (amount) => {
	let value = amount ? amount.toString().trim() : '';
	if (value === '' || !Math.abs(Str.fromUSDToNumber(value)) || _.isNaN(Number(value))) {
	return '';
	}

The Math.abs function is used to get the absolute value of a number, and it is causing the filter to reject values that are very close to zero. Hence we are not able to enter value less than 0.005.

This Bug is a regression from #25663 where it checks for the Math.abs function .

What changes do you think we should make in order to solve the problem?

We just need to remove the check for !Math.abs(Str.fromUSDToNumber(value)), and then we would be able to enter any value amount as we expect in the actual result.

What alternative solutions did you explore? (Optional)

N/A

[ZhenjaHorbach]

Why is this a bug?
For these inputs, we use fromUSDToNumber function
Which limits the minimum value and rounds the value which should correspond to 1 cent (0.005 => 0.01 , 0.004 => 0)

But if we really want to fix this

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank Account - On Test transactions page, invalid amount error displayed when value is less than 0.005

What is the root cause of that problem?

The main problem with issue is that we use fromUSDToNumber function
Which limits the minimum value and rounds the value which should correspond to 1 cent (0.005 => 0.01 , 0.004 => 0)

What changes do you think we should make in order to solve the problem?

To fix this issue we can pass second param for fromUSDToNumber which will allow us doesn't round value

https://github.com/Expensify/expensify-common/blob/dc5f2afce0e3bda2e6bc505a17ab748ba054e275/lib/str.js#L35-L51

We need update fromUSDToNumber function like Str.fromUSDToNumber(value, true)

Here

App/src/pages/ReimbursementAccount/ValidationStep.js

Line 68 in d5f0f6f

if (value === '' || _.isNaN(Number(value)) || !Math.abs(Str.fromUSDToNumber(value))) {

And here

App/src/pages/ReimbursementAccount/ValidationStep.js

Line 74 in d5f0f6f

value = Str.fromUSDToNumber(value);

What alternative solutions did you explore? (Optional)

As an alternative, we can delete all mentions fromUSDToNumber from this component
But I'm not sure how much sense this makes

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The user can not enter values less than 0.005.

What is the root cause of that problem?

In here, the fromUSDToNumber will round values less that 0.005 to 0, leading to the issue, but we have a wider problem below.

Currently we're allowing any currency to have multiple decimals. This is not correct since the minor units are dependent on each currency, for example for USD, there's only cent (0.01) and nothing below that, so 0.001 is an invalid USD value, I believe via USD, we're not able to make a bank transfer with that value (with 3 decimals). If we check the "Request money" feature in our app, it's behaving correctly and will not let you type in more than 2 decimals for USD, for other currencies where there's no minor units like JPY, you won't be able to type decimals at all.

We have a similar issue here where the distance rate is allowed to have multiple decimals, and we decided that it should match the currency minor units (in case of USD it's 2 decimals).

In here we should do the same.

What changes do you think we should make in order to solve the problem?

We should add decimal validation to the input, similar to the distance rate here, the difference is that we should not add 1 to the currency minor units like the distance rate (which was such because of this reason of IRS mileage rate in the US, but that doesn't apply here).

Then, when the user types 3 decimals for USD, it will show an error saying the amount is invalid.

What alternative solutions did you explore? (Optional)

We might want to additionally trim the extra 0 at the end of the decimals, so that '1.230' will still be a valid value because it can be considered the same as '1.23'

[melvin-bot]

@akinwale, @anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!