[HOLD for payment 2024-01-18] [HOLD for payment 2024-01-17] IOU - Merchant editor does not close when removing merchant

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.23-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #33227

Action Performed:

1. Go to 1:1 DM > + > Request money
2. Create a manual request without merchant
3. Open the request details page
4. Click Merchant
5. Add a merchant and save it
6. Click Merchant
7. Empty the merchant and save it
   Note that merchant editor does not close

Expected Result:

The merchant editor closes

Actual Result:

The merchant editor does not close

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6336737_1704809692030.20240109_203416.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Edit merchat modal isn't dismissed on empty value

What is the root cause of that problem?

Seems regerssion from #33227 where we are not dismissing the modal
https://github.com/Expensify/App/pull/33227/files#diff-112aa19f2ab27905a9cd6ce992a483fff32792ea32ede1767f2af6e42e1e548bR161
Earlier we used to call a method editMoneyRequest which dismisses the modal.

What changes do you think we should make in order to solve the problem?

Add dismiss modal line Navigation.dismissModal(); here after updateMoneyRequestMerchant.

App/src/pages/EditRequestPage.js

Lines 161 to 162 in e9f27ab

	IOU.updateMoneyRequestMerchant(transaction.transactionID, report.reportID, CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT);
	return;

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The merchant editor does not close

What is the root cause of that problem?

When newTrimmedMerchant is empty we update merchant but we don't dismiss modal

What changes do you think we should make in order to solve the problem?

Should add Navigation.dismissModal(); in this case

What alternative solutions did you explore? (Optional)

NA

[luacmartins]

This is a regression from my PR. I can work on a fix.

[dangrous]

thanks @luacmartins !