[PAID] [$500] Distance- Expense preview does not show the updated currency when distance currency is changed

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to workspace chat
2. Create a distance request
3. Go to distance details page
4. Click Amount
5. Change the currency and save it
6. Return to expense report page

Expected Result:

The distance preview will show the updated currency

Actual Result:

The distance preview does not show the updated currency

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6333495_1704486668560.20240105_054552.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f1b7774b1ba5d7d3
• Upwork Job ID: 1743373752148869120
• Last Price Increase: 2024-01-05
• Automatic offers:
• jjcoffee | Reviewer | 28091955
• bernhardoj | Contributor | 28091956

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f1b7774b1ba5d7d3

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The currency for distance request preview doesn't update when we update the currency.

What is the root cause of that problem?

This only happens with distance request preview. If we look at the normal review, we get the currency from requestCurrency, but for distance request, we get it from transaction.currency which holds the first currency when we create the transaction.

App/src/components/ReportActionItem/MoneyRequestPreview.js

Lines 223 to 237 in f5a3c02

	const getDisplayAmountText = () => {
	if (isDistanceRequest) {
	return requestAmount && !hasPendingWaypoints ? CurrencyUtils.convertToDisplayString(requestAmount, props.transaction.currency) : translate('common.tbd');
	}
	if (isScanning) {
	return translate('iou.receiptScanning');
	}
	if (TransactionUtils.hasMissingSmartscanFields(props.transaction)) {
	return Localize.translateLocal('iou.receiptMissingDetails');
	}
	return CurrencyUtils.convertToDisplayString(requestAmount, requestCurrency);
	};

requestCurrency itself is coming from TransactionUtils.getCurrency that gets either modifiedCurrency or currency.

App/src/libs/TransactionUtils.ts

Lines 287 to 293 in f5a3c02

	function getCurrency(transaction: OnyxEntry<Transaction>): string {
	const currency = transaction?.modifiedCurrency ?? '';
	if (currency) {
	return currency;
	}
	return transaction?.currency ?? CONST.CURRENCY.USD;
	}

What changes do you think we should make in order to solve the problem?

Use requestCurrency for distance request too

[strepanier03]

Looks good, I'll work on tying this to a wave or VIP tomorrow.