[HOLD for payment 2024-01-26] [$500] Split - Split scan with existing group members is created in both existing and new group chat

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Click FAB > Request money > Manual
2. Split bill with two users
3. Click FAB > Request money > Scan
4. Create a split scan request with the same two users in Step 2
   Note that the split scan creates two same groups, one with the history and another new group. The new group becomes skeleton placeholder after a while

Expected Result:

The split scan request will be created in the existing group chat which is created in Step 2

Actual Result:

The split scan request is created in both existing and new group chat. The request disappears and leaves skeleton placeholder after a while in the new group chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6333455_1704483528937.bandicam_2024-01-05_18-27-06-548.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0147a95509543e3f60
• Upwork Job ID: 1743366914858815488
• Last Price Increase: 2024-01-12
• Automatic offers:
• bernhardoj | Contributor | 28104489

Issue Owner

Current Issue Owner: @stitesExpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0147a95509543e3f60

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[unidev727]

Proposal

from: @unicorndev-727

Please re-state the problem that we are trying to solve in this issue.

Workspace - In Workspace, trying to add a number contact & selecting it, contact disappears

What is the root cause of that problem?

The root cause is that we are using randomly created reportId here.

App/src/pages/iou/request/step/IOURequestStepConfirmation.js

Line 220 in 7ae1ec7

const existingSplitChatReportID = CONST.REGEX.NUMBER.test(reportID) ? reportID : '';

What changes do you think we should make in order to solve the problem?

We don't need to send reportId so that we can find reportId from getChatByParticipants here

App/src/pages/iou/request/step/IOURequestStepConfirmation.js

Lines 222 to 230 in 7ae1ec7

	selectedParticipants,
	currentUserPersonalDetails.login,
	currentUserPersonalDetails.accountID,
	trimmedComment,
	transaction.category,
	transaction.tag,
	receiptFile,
	existingSplitChatReportID,
	);

to

IOU.startSplitBill(
                    selectedParticipants,
                    currentUserPersonalDetails.login,
                    currentUserPersonalDetails.accountID,
                    trimmedComment,
                    transaction.category,
                    transaction.tag,
                    receiptFile
                );

App/src/libs/actions/IOU.js

Lines 1700 to 1702 in 7ae1ec7

	const existingSplitChatReport =
	existingSplitChatReportID || participants[0].reportID
	? allReports[`${ONYXKEYS.COLLECTION.REPORT}${existingSplitChatReportID || participants[0].reportID}`]

screen-capture.2.webm

What alternative solutions did you explore?

We can find existing reportId using getChatByParticipants in ReportUtils for further correctness in IOURequestStepConfirmation page.
const existingSplitChatReportID = ReportUtils.getChatByParticipants(_.map(selectedParticipants, (participant) => Number(participant.accountID))) ?? '';

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Every time we create a new scan split bill, it will create the request on a new group chat.

What is the root cause of that problem?

If we create a scan split bill, it will call startSplitBill. In this function, we check if there is an existing group chat for the split bill, if it doesn't exist, we create a new one.

App/src/libs/actions/IOU.js

Lines 1700 to 1704 in 1752b97

	const existingSplitChatReport =
	existingSplitChatReportID || participants[0].reportID
	? allReports[`${ONYXKEYS.COLLECTION.REPORT}${existingSplitChatReportID || participants[0].reportID}`]
	: ReportUtils.getChatByParticipants(participantAccountIDs);
	const splitChatReport = existingSplitChatReport || ReportUtils.buildOptimisticChatReport(participantAccountIDs);

The way we get the existing group chat is by checking either existingSplitChatReportID and participants[0]?.reportID (for policy expense chat). If it exists, we will get it from the report Onyx object. If not, we will get the report with getChatByParticipants.

However, after the big money request refactor, existingSplitChatReportID always exists because every time we open the money request page, we generate a new random report ID. So, we always trying to get the non-existing report because existingSplitChatReportID is not empty.

What changes do you think we should make in order to solve the problem?

Because existingSplitChatReportID always exists, we can update the condition to,

const existingSplitChatReport = allReports[`${ONYXKEYS.COLLECTION.REPORT}${existingSplitChatReportID}`] || allReports[`${ONYXKEYS.COLLECTION.REPORT}${participants[0]?.reportID}`] || ReportUtils.getChatByParticipants(participantAccountIDs);

What alternative solutions did you explore? (Optional)

The existingSplitChatReportID logic also exists on normal splitBill, but if we look at the splitBill calls, we pass report.reportID to the existingSplitChatReportID params, so we can do the same.

App/src/pages/iou/request/step/IOURequestStepConfirmation.js

Lines 237 to 248 in 0c351a4

	IOU.splitBill(
	selectedParticipants,
	currentUserPersonalDetails.login,
	currentUserPersonalDetails.accountID,
	transaction.amount,
	trimmedComment,
	transaction.currency,
	transaction.merchant,
	transaction.category,
	transaction.tag,
	report.reportID,
	);

[isabelastisser]

@Santhosh-Sellavel please review the proposals above. Thanks!