Room - Member avatar changes after being invited to the room

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.21-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #33077

Action Performed:

1. Go to FAB > Start chat > Room
2. Create a room
3. Open room chat > Click room header
4. Click Members > Invite
5. Invite a few users with default avatar

Expected Result:

The member avatar will not change after being invited to the room

Actual Result:

The member avatar changes after being invited to the room
Each member shares the same default avatar after being invited to the room

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6332185_1704377196286.20240104_155317.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018d16ed2710b34987
• Upwork Job ID: 1743087330455277568
• Last Price Increase: 2024-01-26

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018d16ed2710b34987

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The member avatar changes after being invited to the room
Each member shares the same default avatar after being invited to the room

What is the root cause of that problem?

There're 2 problems:

1. In Invite MemberPage, we use getIcons, but in RoomMemberPage, we use getAvatar that makes the inconsistency
2. InviteRoom API return the new avatar so we can see it's changed after member being invited

What changes do you think we should make in order to solve the problem?

1. We should use getAvatar for icons in here

result.icons = [{
        source:  UserUtils.getAvatar(personalDetail.avatar, personalDetail.accountID),
        type: CONST.ICON_TYPE_AVATAR,
        name: personalDetail.login,
        id: personalDetail.accountID,
    }]

Or we can use getIcons in here
2. BE should be fix to return the correct avatar

What alternative solutions did you explore? (Optional)

NA

[Christinadobrzyn]

Oh yeah, this does happen.

I think this can be part of vip-vsp.

I'm going ooo next week so adding a BZ teammate to monitor this while I'm gone.

Status- we need to review proposals.