[HOLD for payment 2024-02-07] [$500] Web - Chat- Hmm it's not here page displayed on reloading page after selecting Request money

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Login with gmail account on ND site
   2.Go to any 1:1 DM
2. Tap + FAB button
3. Select either Manual, Scan or Distance option
4. Reload page

Expected Result:

Previous opened chat history should display on reloading page after selecting Request money options

Actual Result:

Hmm... it's not here page displayed on reloading page after selecting Request money

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6332682_1704414716168.New_video.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01356e28bc3ed07d0f
• Upwork Job ID: 1743071894141489152
• Last Price Increase: 2024-01-19
• Automatic offers:
• cubuspl42 | Reviewer | 28120404
• DylanDylann | Contributor | 28120405

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01356e28bc3ed07d0f

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[unidev727]

Proposal

from: @unicorndev-727

Please re-state the problem that we are trying to solve in this issue.

Chat- Hmm it's not here page displayed on reloading page after selecting Request money.

What is the root cause of that problem?

The root cause is that we use new reportId(doesn't exist) when we create money request and CustomRouter returns random reportId for CENTRAL_PANE_NAVIGATOR here in this case without checking report.

create/request/start/1/8425039469826829/manual | scan | distance
The route has reportId param so the getLastAccessedReportID doesn't work in these 3 routes.

App/src/libs/Navigation/AppNavigator/createCustomStackNavigator/CustomRouter.ts

Lines 31 to 33 in dc3e19b

	return topmostRoute.params.reportID;
	}

What changes do you think we should make in order to solve the problem?

We should check if report exists regardless reportId is valid here and if report doesn't exist, we shouldn't return that reportId.

App/src/libs/Navigation/AppNavigator/createCustomStackNavigator/CustomRouter.ts

Lines 30 to 32 in dc3e19b

	if (topmostRoute?.params && 'reportID' in topmostRoute.params && typeof topmostRoute.params.reportID === 'string' && topmostRoute.params.reportID) {
	return topmostRoute.params.reportID;
	}

to

if (topmostRoute?.params && 'reportID' in topmostRoute.params && typeof topmostRoute.params.reportID === 'string' && topmostRoute.params.reportID && ReportUtils.getReport(topmostRoute.params.reportID)?.reportID) {
        return topmostRoute.params.reportID;
}

screen-capture.4.webm

What alternative solutions did you explore?

N/A

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hmm... it's not here page displayed on reloading page after selecting Request money

What is the root cause of that problem?

When creating money request via FAB, we'll generate a random reportID and put in the route. When reloading we're unable to find the report associated with that reportID so this issue happens.

What changes do you think we should make in order to solve the problem?

If we're on the request money/split bill/related route, and we cannot find any report matching reportID in Onyx, in here fallback to the getLastAccessedReportID.

We can optionally optimistically create the report for those reportID as well, with the isOptimisticReport: true field, and when we find the request money/split bill report by the reportID, if what we found is an optimistic report, then fallback to using getLastAccessedReportID. We can then clear this optimistic report when we complete/get out of the money request flow.

What alternative solutions did you explore? (Optional)

NA

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hmm... it's not here page displayed on reloading page after selecting Request money

What is the root cause of that problem?

When we create money request via FAB, we generate a random reportID and put in the route.
This random reportID make this issue.

What changes do you think we should make in order to solve the problem?

We need to compare route?.params?.reportID and getLastAccessedReportID here

if (route?.params?.reportID === reportID) {

What alternative solutions did you explore? (Optional)

Screen.Recording.2024-01-05.at.7.02.48.AM.mov

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Web - Chat- Hmm it's not here page displayed on reloading page after selecting Request money

What is the root cause of that problem?

• When we open the app by the deeplink https://dev.new.expensify.com:8082/create/request/start/1/317873788367143/manual, we add the report to the CENTRAL_PANE_NAVIGATOR by the below function:
  

  App/src/libs/Navigation/AppNavigator/createCustomStackNavigator/CustomRouter.ts

  Lines 42 to 43 in 6fad557

  	const addCentralPaneNavigatorRoute = (state: State) => {
  	const reportID = getTopMostReportIDFromRHP(state);

• In this case, the getTopMostReportIDFromRHP will return the 317873788367143, it is the random reportID is generated when we create iou request and have null value, that leads to the "Hmm it`s not here page" screen displayed.

What changes do you think we should make in order to solve the problem?

• We need to make sure when we open the deeplink https://dev.new.expensify.com:8082/create/request/start/1/317873788367143/manual, app does not add the report screen with reportID = 317873788367143 to CENTRAL_PANE_NAVIGATOR
• We can do it by updating getTopMostReportIDFromRHP to:

const getTopMostReportIDFromRHP = (state: State): string => {
    if (!state) {
        return '';
    }
    const topmostRightPane = state.routes.filter((route) => route.name === NAVIGATORS.RIGHT_MODAL_NAVIGATOR).at(-1);

    if (topmostRightPane?.state) {
        return getTopMostReportIDFromRHP(topmostRightPane.state);
    }
    const topmostRoute = state.routes.at(-1);
+  if (topmostRoute?.params && topmostRoute.params.iouType === "request") {
+        return '';
+    }

    if (topmostRoute?.state) {
        return getTopMostReportIDFromRHP(topmostRoute.state);
    }
    if (topmostRoute?.params && 'reportID' in topmostRoute.params && typeof topmostRoute.params.reportID === 'string' && topmostRoute.params.reportID) {
        return topmostRoute.params.reportID;
    }

    return '';
};

What alternative solutions did you explore? (Optional)

• NA