[HOLD for payment 2024-03-13] [HOLD for payment 2024-02-20] [$500] [MEDIUM] Distance - Address is duplicated when dragging one point over an empty point

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.21-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to workspace chat > + > Request money > Distance
2. Click Finish
3. Enter an address and save it
4. Hold and drag the Finish point above the Start point

Expected Result:

The Finish point will become Start point

Actual Result:

The Finish point is duplicated to become Start point
This issue also occurs when dragging Start point with address to below empty Finish point

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6331780_1704328200276.20240104_034302.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019049b6059932909e
• Upwork Job ID: 1742713103147515904
• Last Price Increase: 2024-01-04
• Automatic offers:
• tienifr | Contributor | 28081723

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019049b6059932909e

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Finish point is duplicated to become Start point
This issue also occurs when dragging Start point with address to below empty Finish point

What is the root cause of that problem?

In here, we're not clearing the empty waypoint by using removeWaypoint, so when we update in Onyx, it will not override the existing waypoint, leading to duplicate waypoint.

What changes do you think we should make in order to solve the problem?

Use removeWaypoint to remove the empty waypoints when dragging.

More detailed steps:

• Find waypoints that currently is not empty but become empty after the drag
• Use removeWaypoint on them to remove them from Onyx. We can modify the removeWaypoint method to removeWaypoints and allow removing multiple waypoints at once
• updateWaypoints, then removeWaypoints in here. This might require returning the Onyx.set inside removeWaypoints so we can wait for it, similar to how we wait for the updateWaypoints. We can also optimize it by merging these 2 operations to allow both removing and updating waypoints in 1 Onyx.set operation (something like removeAndUpdateWaypoints), but this will require some refactoring.

What alternative solutions did you explore? (Optional)

NA

[aim-salam]

.

[parasharrajat]

@tienifr's proposal makes sense to me.

🎀 👀 🎀 C+ reviewed