[HOLD for payment 2024-01-18] IOU - Merchant field in editor is empty when the Merchant is manually set to Unknown Merchant

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.20-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Click FAB > Request money > Manual
2. Create a manual request with a user with "Unknown Merchant" as the merchant
3. Navigate to request details page
4. Click Merchant
5. Merchant field is empty

Expected Result:

Merchant field in editor shows "Unknown Merchant"

Actual Result:

Merchant field in editor is empty, when it shows "Unknown Merchant" in the details page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6329830_1704112236784.20231230_201606__1_.1.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @rlinoz (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Merchant field in editor is empty when the Merchant is manually set to Unknown Merchant

What is the root cause of that problem?

in the EditRequestMerchantPage component, we set the merchant to empty based on this condition

App/src/pages/EditRequestMerchantPage.js

Line 30 in fe49e4f

const isEmptyMerchant = defaultMerchant === '' || defaultMerchant === CONST.TRANSACTION.UNKNOWN_MERCHANT || defaultMerchant === CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT;

What changes do you think we should make in order to solve the problem?

remove defaultMerchant === CONST.TRANSACTION.UNKNOWN_MERCHANT so it should be like this:

    const isEmptyMerchant = defaultMerchant === '' || defaultMerchant === CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT;

[DylanDylann]

@mountiny This issue has the same root cause as this one. I think we should create a thread to discuss and confirm the final expect