Scan - No validation error when saving empty merchant in Scan details page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.20-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause- Internal Team
Slack conversation:

Action Performed:

1. Click FAB > Request money > Scan
2. Create a scan request
3. Navigate to scan details page
4. Click Amount and enter amount manually
5. Click Merchant
6. Save the empty merchant

Expected Result:

Validation error will appear because merchant is a required field

Actual Result:

There is no validation error when merchant is a required field

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6329824_1704111071318.20231230_204107__1_.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ishpaul777]

Not a bug, The validation is only for policyExpenseChat specifically

App/src/pages/EditRequestMerchantPage.js

Lines 32 to 37 in b3fe02a

	const validate = useCallback(
	(value) => {
	const errors = {};
	if (_.isEmpty(value.merchant) && value.merchant.trim() === '' && isPolicyExpenseChat) {
	errors.merchant = 'common.error.fieldRequired';
	}

[srikarparsi]

I agree, closing this out, cc @mountiny for a double check since you worked on this PR.