[$500] [HOLD for payment 2024-01-18] Web - Double <Payer:> for IOU report preview in Search

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.19-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. [User A] Request money from User B.
2. [User B] Pay the request.
3. [User A] Click on the IOU preview to open IOU report.
4. [User A] Click Search icon.
5. Note that the IOU report shows double Payer: in the preview in Search list.

Expected Result:

Single Payer: for IOU report preview in Search

Actual Result:

Double Payer: for IOU report preview in Search

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

20231229_223646.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016165d0cee06c5ac9
• Upwork Job ID: 1748381394601844736
• Last Price Increase: 2024-01-19

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kbecciv]

Issue is not Reproduced on production

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

We prepend the payer name twice:

App/src/libs/ReportUtils.ts

Lines 2029 to 2032 in 8432563

	const actualPayerName = report.managerID === currentUserAccountID ? '' : `${getDisplayNameForParticipant(report.managerID, true)}:`;
	const payerDisplayName = isPreviewMessageForParentChatReport ? payerName : actualPayerName;
	return Localize.translateLocal(translatePhraseKey, {amount: formattedAmount, payer: payerDisplayName ?? ''});

And:

App/src/libs/OptionsListUtils.js

Lines 512 to 516 in 9692e48

	const lastMessageTextFromReport = getLastMessageTextForReport(report);
	const lastActorDetails = personalDetailMap[report.lastActorAccountID] || null;
	const lastActorDisplayName =
	hasMultipleParticipants && lastActorDetails && lastActorDetails.accountID !== currentUserAccountID ? lastActorDetails.firstName || lastActorDetails.displayName : '';
	let lastMessageText = lastActorDisplayName ? `${lastActorDisplayName}: ${lastMessageTextFromReport}` : lastMessageTextFromReport;

What changes do you think we should make in order to solve the problem?

Since the lastMessageTextFromReport has changed for the money reports to include the payer name, we should handle this case and set result.alternateText to only lastMessageTextFromReport, not lastMessageText for such options.

We currently do similar thing for tasks:

App/src/libs/OptionsListUtils.js

Lines 532 to 534 in 9692e48

	} else if (result.isTaskReport) {
	result.alternateText = showChatPreviewLine && lastMessageText ? lastMessageTextFromReport : Localize.translate(preferredLocale, 'report.noActivityYet');
	} else {

What alternative solutions did you explore? (Optional)

[mountiny]

I think this was known and wanted to address in a follow up @koko57

[koko57]

It was occuring long before the merge and I found it while I was working on it (it was spotted by me on staging) #30042 (comment)

it displayed [firstName lastName]: [firstName]: but after my changes I had to make for LHN it displays firstName doubled. We agreed that it will be fixed in a separate PR