[HOLD for payment 2024-02-07] [$500] iOS - Chat - Extra padding below emoji skin tone selection when keyboard is up

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.18-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch New Expensify app.
2. Go to any chat.
3. Tap Emoji picker.
4. Tap on the search field

Expected Result:

There is no extra padding below emoji skin tone selection when keyboard is up.

Actual Result:

There is extra padding below emoji skin tone selection when keyboard is up.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Android app

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0138e4bd2af0cf89e1
• Upwork Job ID: 1740394654609428480
• Last Price Increase: 2024-01-04
• Automatic offers:
• situchan | Reviewer | 28083374
• mkhutornyi | Contributor | 28083375

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0138e4bd2af0cf89e1

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Chat - Extra bottom padding on emoji picker modal when keyboard is up

What is the root cause of that problem?

shouldAddBottomSafeAreaPadding is true when modal type is BOTTOM_DOCKED
This is intentional to avoid modal being overlapped by iOS bottom safe area.

When we have input on modal and focus on it, keyboard shows.
We're already using avoidKeyboard prop to push modal above keyboard.
In this case, bottom safe area doesn't apply but still has bottom padding which causes this issue.

What changes do you think we should make in order to solve the problem?

add useKeyboardState hook in BaseModal.
And if keyboard is shown, don't add paddingBottom so this condition can be updated like this:

App/src/components/Modal/BaseModal.tsx

Line 164 in d0c3e31

shouldAddBottomSafeAreaPadding,

 shouldAddBottomSafeAreaPadding: !isKeyboardShown && shouldAddBottomSafeAreaPadding, 

What alternative solutions did you explore? (Optional)

Introduce keyboardVeritcalOffset prop in react-native-modal, similar to react-native's KeyboardAvoidingView prop. This will require upstream fix or local patch

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

This is happening because of the safe area bottom padding: StyleUtils.getModalStyles returns shouldAddBottomSafeAreaPadding: true for the BOTTOM_DOCKED modal:

App/src/styles/utils/generators/ModalStyleUtils.ts

Line 186 in 27812e9

shouldAddBottomSafeAreaPadding = true;

When the keyboard opens, we do not remove this padding.

What changes do you think we should make in order to solve the problem?

We should add another parameter: isKeyboardShown = false to the StyleUtils.getModalStyles. And use it only for the BOTTOM_DOCKED modal:

shouldAddBottomSafeAreaPadding = !isKeyboardShown;

App/src/styles/utils/generators/ModalStyleUtils.ts

Lines 169 to 190 in 75597c4

	case CONST.MODAL.MODAL_TYPE.BOTTOM_DOCKED:
	modalStyle = {
	...modalStyle,
	...{
	alignItems: 'center',
	justifyContent: 'flex-end',
	},
	};
	modalContainerStyle = {
	width: '100%',
	borderTopLeftRadius: 20,
	borderTopRightRadius: 20,
	paddingTop: 12,
	justifyContent: 'center',
	overflow: 'hidden',
	};
	shouldAddBottomSafeAreaPadding = true;
	swipeDirection = undefined;
	animationIn = 'slideInUp';
	animationOut = 'slideOutDown';
	break;

Also, use the const {isKeyboardShown} = useKeyboardState() hook in BaseModal and pass it as a parameter to StyleUtils.getModalStyles here:

App/src/components/Modal/BaseModal.tsx

Lines 136 to 146 in 43927e9

	StyleUtils.getModalStyles(
	type,
	{
	windowWidth,
	windowHeight,
	isSmallScreenWidth,
	},
	popoverAnchorPosition,
	innerContainerStyle,
	outerStyle,
	),

What alternative solutions did you explore? (Optional)

[dzakki]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no extra padding below emoji skin tone selection when keyboard is up.

What is the root cause of that problem?

the component App/src/components/Modal/BaseModal.tsx already has default padding-bottom, and the emoji give extra padding-bottom too. that makes look has over padding-bottom area when the keyboard is active

What changes do you think we should make in order to solve the problem?

add condition to remove padding bottom when the keyboard is active (useKeyboardState) and the device is IOS (getOperatingSystem)

isKeyboardActive && Device === 'CONST.OS.IOS' then remove the padding-bottom

App/src/components/EmojiPicker/EmojiSkinToneList.js

Line 37 in 75597c4

<View style={[styles.flexRow, styles.p3, styles.ph4, styles.emojiPickerContainer]}>

What alternative solutions did you explore? (Optional)