[$500] Avatar - Avatar is blank instead of placeholder and no spinner when loading it offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.17-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal
Slack conversation:

Action Performed:

1. Launch New Expensify app.
2. Go offline.
3. Tap Search.
4. Search for users with custom avatar.
5. Tap on the user with blank custom avatar.
6. Tap on the chat head
7. Tap on the avatar

Expected Result:

In Step 4, users with custom avatar will show the avatar placeholder (production behavior - circular head with body with green background).
In Step 7, spinner will be shown when loading user avatar.

Actual Result:

In Step 4, the users with custom avatar are blank and gray.
In Step 7, the spinner only appears for a split second.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6326350_1703616605864.staging.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017c4e38b1b18578d0
• Upwork Job ID: 1739771161764048896
• Last Price Increase: 2024-01-23
• Automatic offers:
• aswin-s | Contributor | 28129529
• dukenv0307 | Contributor | 28135456

Issue Owner

Current Issue Owner: @bfitzexpensify

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kbecciv]

Issue is not reproducible on production

Bug6326350_1703616605871.production.mp4

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[marcaaron]

I guess either related to personal details or the search page. This PR looks the most likely culprit, but have not reverted to test the theory yet.