[HOLD for payment 2024-01-11] [$500] Status - Unable to set custom time after selecting the duration

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.15-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to Settings > Profile > Status.
2. Click Clear after.
3. Select 30 minutes.
4. Click Clear after.
5. Click Date under Custom.
6. Select a different date.

Expected Result:

The selected date is saved.

Actual Result:

The selected date is not saved.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6322802_1703170066823.bandicam_2023-12-21_21-40-14-801.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f4c9ce5463b9747c
• Upwork Job ID: 1737863065032630272
• Last Price Increase: 2023-12-21
• Automatic offers:
• paultsimura | Contributor | 28067990

Issue Owner

Current Issue Owner: @tylerkaraszewski

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f4c9ce5463b9747c

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Changing date in Status' DatePicker does nothing.

What is the root cause of that problem?

When selecting the date value, the actual form's value of the wrapping <FormProvider> is not updated because the DatePicker is not properly wrapped in the <InputWrapper>

What changes do you think we should make in order to solve the problem?

We should use <InputWrapper> here:

                <InputWrapper
                    InputComponent={DatePicker}
                    inputID="dateTime"
                    label={translate('statusPage.date')}
                    defaultValue={DateUtils.extractDate(customClearAfter)}
                    minDate={new Date()}
                />

App/src/pages/settings/Profile/CustomStatus/SetDatePage.js

Lines 61 to 66 in fd71747

	<DatePicker
	inputID="dateTime"
	label={translate('statusPage.date')}
	defaultValue={DateUtils.extractDate(customClearAfter)}
	minDate={new Date()}
	/>

What alternative solutions did you explore? (Optional)

[parasharrajat]

@paultsimura's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.