[PAID] [$500] Status - Custom time page loads infinitely in offline mode

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.14-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Log in and do not visit custom time page
2. Go offline
3. Go to Settings > Profile > Status
4. Click Clear after
5. Click Custom
6. Click Time

Expected Result:

Time selection page will open without issue

Actual Result:

Time selection page loads infinitely

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6321550_1703091917140.bandicam_2023-12-20_21-58-55-875.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ab5fa243901ed9cb
• Upwork Job ID: 1737525375053193216
• Last Price Increase: 2023-12-20
• Automatic offers:
• paultsimura | Contributor | 28067092

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ab5fa243901ed9cb

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Status - Custom time page loads infinitely in offline mode

What is the root cause of that problem?

setTimePage shows FullScreenLoadingIndicator if is it still loading:

App/src/pages/settings/Profile/CustomStatus/SetTimePage.js

Lines 36 to 38 in 88631a0

	if (lodashGet(privatePersonalDetails, 'isLoading', true)) {
	return <FullscreenLoadingIndicator />;
	}

This will keep on loading when offline

What changes do you think we should make in order to solve the problem?

We should add a FullPageOfflineBlockingView when the user is offline

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Time selection page loads infinitely

What is the root cause of that problem?

When we offline without private personal detail, the loading page is show here

App/src/pages/settings/Profile/CustomStatus/SetTimePage.js

Line 36 in 88631a0

if (lodashGet(privatePersonalDetails, 'isLoading', true)) {

What changes do you think we should make in order to solve the problem?

I think on this page, we want to get currentPersonalDetail to get the current time to display the default value of the form if the draft time is empty but we get the wrong data here.

We should get currentPersonalDetail by using withCurrentPersonalDetail HOC and then get clearAfter from currentPersonalDetail.status to display if the draft custom status is empty.

App/src/pages/settings/Profile/CustomStatus/SetTimePage.js

Line 36 in 88631a0

if (lodashGet(privatePersonalDetails, 'isLoading', true)) {

And we can display loading page when currentPersonalDetail.login is empty.

We should update other custom status pages with this approach.

What alternative solutions did you explore? (Optional)

NA

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In offline, the status timer is always loading.

What is the root cause of that problem?

We are checking for the privatePersonalDetails to be loaded before showing the TimePicker and displaying the loader otherwise:

App/src/pages/settings/Profile/CustomStatus/SetTimePage.js

Lines 36 to 38 in 88631a0

	if (lodashGet(privatePersonalDetails, 'isLoading', true)) {
	return <FullscreenLoadingIndicator />;
	}

What changes do you think we should make in order to solve the problem?

I've checked the code – the value of privatePersonalDetails is not used anywhere, seems like it is a redundant code that was missed during development (probably, this page was initially copy-pasted from some other that uses privatePersonalDetails, most likely from DateOfBirthPage – commit).

We can remove this piece of code as well as all the code related to the privatePersonalDetails on this page:

App/src/pages/settings/Profile/CustomStatus/SetTimePage.js

Lines 36 to 38 in 88631a0

	if (lodashGet(privatePersonalDetails, 'isLoading', true)) {
	return <FullscreenLoadingIndicator />;
	}

What alternative solutions did you explore? (Optional)

[narefyev91]

Proposal from @paultsimura looks good to me #33369 (comment)
Seems we do not need that check, in case we do not use privatePersonalDetails anywhere in that flow
🎀 👀 🎀 C+ reviewed