[HOLD for payment 2024-01-11] [$500] Welcome message - Hmm its not here not displayed for wrong link

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.13-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open the app
2. Open #announce of workspace of which you are admin
3. Click on header and open settings - >welcome message
4. Copy the link and paste in the report
5. Modify the link and send eg: Add 's' in the end
6. Click on modified link and observe that nothing happens

Expected Result:

App should display 'hmm its not here' page for wrong welcome message link click

Actual Result:

App does nothing on wrong welcome message link click

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6317830_1702894772827.windows_chrome_-_hmm_its_not_here_not_displayed.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fb5caa50cbb1c6aa
• Upwork Job ID: 1736751063588982784
• Last Price Increase: 2023-12-25
• Automatic offers:
• shubham1206agra | Reviewer | 28071736
• samilabud | Contributor | 28071737

Issue Owner

Current Issue Owner: @shubham1206agra

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fb5caa50cbb1c6aa

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[samilabud]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Welcome message - Hmm its not here not displayed for wrong link

What is the root cause of that problem?

We are not validating the URL route for the second parameter when we are building our routes for 'r' parameter in https://github.com/Expensify/App/blob/main/src/ROUTES.ts. e.g:

App/src/ROUTES.ts

Line 199 in 11d7821

route: 'r/:reportID/welcomeMessage',

What changes do you think we should make in order to solve the problem?

We should validate if the link URL exists in our routes rules, if not then return our custom 404 error.

To do this we should edit the component ReportScreenIDSetter
, first, validate the reportActionID which should be numeric, and if not return the user to the last report page (chat window).

We should add this at the top of the current use effect like:

const reportActionID = route?.params?.reportActionID;
        const regexValidReportActionID = new RegExp(/^\d*$/);
        if (reportActionID && !regexValidReportActionID.test(reportActionID)) {
            Navigation.goBack(ROUTES.HOME);
            return;
        }

This is the result:
Before changes:

Before.changes.reporte.screen.report.id.mp4

After changes:

After.changes.report.screen.report.id.mp4

[mkhutornyi]

I think this should be handled as part of comment linking project
cc: @roryabraham

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Welcome message - Hmm its not here not displayed for wrong link

What is the root cause of that problem?

Because handle by this

What changes do you think we should make in order to solve the problem?

need to update

RANDOM_URL: {
        route: 'r/:reportID?',
        getRoute: (reportID: string, any: string) => ` r/${reportID}` as const,
}

What alternative solutions did you explore? (Optional)

[unidev727]

Proposal

from: @unicorndev-727

Please re-state the problem that we are trying to solve in this issue.

For the optimistic account, the ReportWelcomeText shows the email as text, not a link.

What is the root cause of that problem?

The root cause is that r/:reportId/welcomeMessages is converted to r/:reportID?/:reportActionID? and the Report page will be displayed and we didn't check if reportActionId is valid.

What changes do you think we should make in order to solve the problem?

If the format of route is r/:reportID?/:reportActionID? and is not isModalNavigator, we should check if reportActionId is valid.
If not valid, should return 404 error page here.

App/src/libs/Navigation/linkTo.ts

Line 108 in 7515847

if (action && 'payload' in action && action.payload && 'name' in action.payload && isModalNavigator(action.payload.name)) {

What alternative solutions did you explore? (Optional)

N/A