[HOLD for payment 2024-01-02] [$500] App unusable on Safari 16.3

[Julesssss]

CC @rojiphil @jjcoffee

---

Version Number: ?
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1702869444870729

Action Performed:

• Open app
• Should not see error
  

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b9ae6039965bf1b0
• Upwork Job ID: 1736762561116237824
• Last Price Increase: 2023-12-18
• Automatic offers:
• rojiphil | Contributor | 28064568
• situchan | Contributor | 28065190

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Julesssss]

@anmurali we might already know the fix. Let's not make it external just yet.

[jjcoffee]

@anyongjitiger Tagging you in here as you worked on the PR that (probably) caused this.

[Julesssss]

Not going to count this as a regression, as it's impossible to test old safari versions... so we'll treat it as a new issue, with a regular bounty

[Julesssss]

@rojiphil are you interested in working on this bug?

[rojiphil]

@rojiphil are you interested in working on this bug?

@Julesssss
Yes. Would be interested.
I think we can do this using capture groups
Let me look at the issue.
Will get back within an hour.

[rojiphil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In older versions of Safari (i.e. 16.3) , the app does not load.

What is the root cause of that problem?

Older versions of Safari do not support lookbehind regex. So, here, the regex uses lookbehind regex. This is the root cause.

What changes do you think we should make in order to solve the problem?

We can solve the problem using capture groups as follows here

    const match = avatarURL.match(/(default-avatar_)(\d+)(?=\.)/);
    const lastDigit = match && parseInt(match[2], 10);

What alternative solutions did you explore? (Optional)

[rojiphil]

@Julesssss
Have sent a proposal.
I can raise a PR immediately.

[Julesssss]

Thank you, I'll assign a C+ for the PR review.