[HOLD for payment 2024-01-11] [$500] Expense - Missing "Required" and "Request" for Category & Tag and Merchant respectively

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.12-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

• User is an employee of a Collect workspace on OD.
• The workspace has set Category and Tag to required.

1. Go to the Collect workspace chat.
2. Click + > Request money > Manual.
3. Enter amount > Next.

Expected Result:

On confirmation page,

• "Required" is shown on Category and Tag row.
• "Request" is shown in Merchant field by default.

Actual Result:

On confirmation page,

• "Required" is not shown on Category and Tag row.
• "Request" is not shown in Merchant field by default.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6313118_1702562788963.20231214_035340.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018b84474aa7b66f4e
• Upwork Job ID: 1735302826178007040
• Last Price Increase: 2023-12-14
• Automatic offers:
• shubham1206agra | Reviewer | 28066311
• DylanDylann | Contributor | 28066312

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018b84474aa7b66f4e

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[kbecciv]

Production on previous build

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Missing "Required" and "Request" for Category & Tag and Merchant respectively

What is the root cause of that problem?

We have not passed the right label prop for category and tag here

What changes do you think we should make in order to solve the problem?

We should pass the prop if policy requires category and tag:

rightLabel={Boolean(props.policy.requiresCategory) ? translate('common.required') : ''} 

rightLabel={Boolean(props.policy.requiresTag) ? translate('common.required') : ''}

We may also have a canUseViolations check.

[GItGudRatio]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Missing "Required" and "Request" for Category & Tag and Merchant respectively

What is the root cause of that problem?

The rightLabel prop is passed correctly in these places:

• App/src/components/MoneyRequestConfirmationList.js

  Line 713 in fa87f8b

  rightLabel={canUseViolations && Boolean(props.policy.requiresCategory) ? translate('common.required') : ''}

• App/src/components/MoneyRequestConfirmationList.js

  Line 732 in fa87f8b

  rightLabel={canUseViolations && Boolean(props.policy.requiresTag) ? translate('common.required') : ''}

However, it is not used here:

• App/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js

  Lines 712 to 724 in 89cc721

  	<MenuItemWithTopDescription
  	shouldShowRightIcon={!isReadOnly}
  	title={iouCategory}
  	description={translate('common.category')}
  	numberOfLinesTitle={2}
  	onPress={() =>
  	Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_CATEGORY.getRoute(iouType, transaction.transactionID, reportID, Navigation.getActiveRouteWithoutParams()))
  	}
  	style={[styles.moneyRequestMenuItem]}
  	titleStyle={styles.flex1}
  	disabled={didConfirm}
  	interactive={!isReadOnly}
  	/>

This is the function responsible for rendering the component here:

App/src/pages/iou/request/step/IOURequestStepConfirmation.js

Line 8 in aace20d

import MoneyRequestConfirmationList from '@components/MoneyTemporaryForRefactorRequestConfirmationList';

What changes do you think we should make in order to solve the problem?

We need to add the conditional properly, along with the usePermissions hook.
const {canUseViolations} = usePermissions();

rightLabel={canUseViolations && Boolean(props.policy.requiresCategory) ? translate('common.required') : ''}

rightLabel={canUseViolations && Boolean(props.policy.requiresTag) ? translate('common.required') : ''}

What alternative solutions did you explore? (Optional)

N/A

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On confirmation page,

"Required" is shown on Category and Tag row.
"Request" is shown in Merchant field by default.

What is the root cause of that problem?

1. In IOURequestStepConfirmation, we don't set rigthLabel for Tag and Category.
2. We don't have logic to prevent the user from requesting money if category/tag is required and the user doesn't select category/tag.
3. In the manual request, split bill, scan request, the default merchant is empty

What changes do you think we should make in order to solve the problem?

1. In 2 places
   

   App/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js

   Line 713 in 3a44f77

   <MenuItemWithTopDescription

   
   

   App/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js

   Line 728 in 3a44f77

   <MenuItemWithTopDescription

we should add

rightLabel={canUseViolations && Boolean(props.policy.requiresCategory) ? translate('common.required') : ''}

rightLabel={canUseViolations && Boolean(props.policy.requiresTag) ? translate('common.required') : ''}

And then in here

App/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js

Line 504 in 3a44f77

we should add an error handling if category/tag is required and the user doesn't select category/tag.

if (!iouCategory) {
  setFormError('common.error.invalidCategory');
  return;
}
if (!iouTag) {
  setFormError('common.error.invalidTag');
  return;
}

In en.ts and es.ts we also need to add the translation for 'common.error.invalidCategory' and 'common.error.invalidTag'

2. In the manual request, split bill, scan request, we should set deafult merchant is 'Request'. To do that, in here

   App/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js

   Line 694 in 961d501

   title={iouMerchant}

   
   we should update like this

title={iouMerchant || CONST.TRANSACTION.DEFAULT_MERCHANT} 

like we did with the date field

App/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js

Line 660 in 961d501

title={iouCreated || format(new Date(), CONST.DATE.FNS_FORMAT_STRING)}

And then when requesting money we also do the same thing: checking if iouMerchant is empty we will use CONST.TRANSACTION.DEFAULT_MERCHANT

Result

Screen.Recording.2023-12-15.at.14.12.59.mov