[$500] Chat-Email id is not shown as link and directed to profile page.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.12
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Go to https://staging.new.expensify.com/

2. Tap fab

3. Tap start chat

4. Enter a new contact eg: y@c.com

5. Select the contact

6. Tap on the email id displayed in start of page

7. Note it directs to profile page

8. Navigate back to LHN

9. Tap profile icon --- preferences

10. Toggle on forced offline

11. Repeat step 2-- step6

Expected Result:

Email id must be shown as link and directed to profile page.

Actual Result:

Tapping on email id, displays it as text and not link. Email id is not shown as link and directed to profile page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6312311_1702507076813.display_not_as_link.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010c805ba2ca605e54
• Upwork Job ID: 1735232276090773504
• Last Price Increase: 2023-12-14

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010c805ba2ca605e54

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

For the optimistic account, the ReportWelcomeText shows the email as text, not a link.

What is the root cause of that problem?

The optimistic account's data is not full, therefore showing a Profile page was leading to a broken behavior, so it was decided to render only a non-clickable text in offline mode:

App/src/components/ReportWelcomeText.js

Lines 113 to 123 in d521dd6

	{ReportUtils.isOptimisticPersonalDetail(accountID) ? (
	<Text style={[styles.textStrong]}>{displayName}</Text>
	) : (
	<Text
	style={[styles.textStrong]}
	onPress={() => Navigation.navigate(ROUTES.PROFILE.getRoute(accountID))}
	suppressHighlighting
	>
	{displayName}
	</Text>
	)}

However, there is another page – Details page, that should have been used instead of Profile in such cases.

What changes do you think we should make in order to solve the problem?

Instead of showing just text, we should show a clickable UserDetailsTooltip for both optimistic & real accounts.
But in case of an optimistic account, navigate to the Details page instead of the Profile page:

<UserDetailsTooltip accountID={accountID}>
    <Text
        style={[styles.textStrong]}
        onPress={() => Navigation.navigate(ReportUtils.isOptimisticPersonalDetail(accountID) ? ROUTES.DETAILS.getRoute(displayName) : ROUTES.PROFILE.getRoute(accountID))}
        suppressHighlighting
    >
        {displayName}
    </Text>
</UserDetailsTooltip>

Result (both optimistic & full account):

Screen.Recording.2023-12-14.at.10.53.44-compressed.mp4

What alternative solutions did you explore? (Optional)

[situchan]

@paultsimura's proposal looks good to me.
It makes sense to go details page when accountID is optimistic or doesn't exist.
Also aligned with user mention logic here.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @dangrous, see https://stackoverflow.com/c/expensify/questions/7972 for more details.