[HOLD for payment 2024-01-11] [$500] IOU - While editing amount for manual request with receipt, "next" button is displayed below

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.12
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap fab
3. Tap request money ----Manual
4. Enter an amount
5. Tap next
6. Select a contact
7. Tap 3 dots on top right and add a receipt
8. Tap request
9. Tap on the manual request newly created
10. Tap on amount & change the amount
11. Note Next button displayed below
12. Tap description and note Save button displayed below

Expected Result:

While editing amount for manual request with receipt, "next" button must be displayed

Actual Result:

While editing amount for manual request with receipt, "next" button is displayed below instead of "save" button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6312163_1702497303682.next.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0159762618665c827d
• Upwork Job ID: 1735034314000285696
• Last Price Increase: 2023-12-13
• Automatic offers:
• situchan | Reviewer | 28062582
• neonbhai | Contributor | 28062583

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0159762618665c827d

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

While editing amount for manual request with receipt, "next" button is displayed below

What is the root cause of that problem?

We don't pass the isEditing prop in EditRequestAmountPage here:

App/src/pages/EditRequestAmountPage.js

Lines 51 to 58 in 3df907c

	<MoneyRequestAmountForm
	buttonTranslationText="common.save"
	currency={defaultCurrency}
	amount={defaultAmount}
	ref={(e) => (textInput.current = e)}
	onCurrencyButtonPress={onNavigateToCurrency}
	onSubmitButtonPress={onSubmit}
	/>

isEditing is false by default, and this makes the button text as "next":

App/src/pages/iou/steps/MoneyRequestAmountForm.js

Line 251 in 3df907c

const buttonText = isEditing ? translate('common.save') : translate('common.next');

What changes do you think we should make in order to solve the problem?

We should pass the isEditing prop here

[samilabud]

Proposal

Please re-state the problem that we are trying to solve in this issue.

While editing amount for manual request with receipt, "next" button is displayed below

What is the root cause of that problem?

When we use the MoneyRequestView component to open EditRequestAmountPage component we should specify that we are editing.

What changes do you think we should make in order to solve the problem?

We should pass the editing prop in EditRequestAmountPage component as true like:

<MoneyRequestAmountForm
                buttonTranslationText="common.save"
                currency={defaultCurrency}
                amount={defaultAmount}
                ref={(e) => (textInput.current = e)}
                onCurrencyButtonPress={onNavigateToCurrency}
                onSubmitButtonPress={onSubmit}
                isEditing
            />

Result:

Screen.Recording.2023-12-13.at.4.51.05.PM.mov

[isabelastisser]

@situchan can you please review the proposals above? Thanks!

[situchan]

@neonbhai's proposal looks good to me.
Let's also remove buttonTranslationText which is no longer used.
🎀 👀 🎀 C+ reviewed