[HOLD for payment 2023-12-28] [$500] Login - "Account closed successfully" on login screen not shown for old existing accounts

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.10-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Log in New Expensify with an old existing account
2. Navigate to Settings > Security > Close account
3. Enter default contact method and close account

Expected Result:

User should be redirected to the log in page and an "Account closed successfully" message should be displayed below email field

Actual Result:

User is redirected to the log in page. However, the message indicating account closure is not shown
Notes:
Issue is not reproducible with completely new accounts

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6305807_1702050927436.2023-12-08_16-24-44.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011705658b0d3f1aa4
• Upwork Job ID: 1733186029523935232
• Last Price Increase: 2023-12-08
• Automatic offers:
• bernhardoj | Contributor | 28042756

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011705658b0d3f1aa4

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[shubham1206agra]

@ZhenjaHorbach, Your RCA is wrong. I have tested this. Its closing the account.
@stephanieelliott Can we check the backend for this? It looks like a backend issue as success message comes from backend

[ZhenjaHorbach]

Yeah
Sorry

But what's interesting is that we expect the parameter here
Which should be responsible for the error message

https://github.com/Expensify/App/blob/6e11da581e1322b144abc0a1220bd7acac9f25ea/src/libs/actions/User.js#L72C1-L73

[shubham1206agra]

Ah, maybe I can guess the problem here. And why the problem is with the old account only?

[shubham1206agra]

Yeah Sorry

But what's interesting is that we expect the parameter here Which should be responsible for the error message

The parameter is optional in that