[HOLD for payment 2024-01-04] [$500] Desktop - Login - Magic code is sent twice or more after double tapping "Enter" button

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.8-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Log out of NewDot
2. Enter an email in the login form that you have access to
3. Press the enter key on the keyboard two times quickly
4. Navigate to your email inbox
5. Verify that the magic code is sent only once

Expected Result:

The magic code is sent only once

Actual Result:

Magic code is sent twice or more after quickly double tapping "Enter" button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6300988_1701718405511.Magic_code_sent_multiple_times_-_ND.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01837f964a8d992695
• Upwork Job ID: 1732053574883385344
• Last Price Increase: 2023-12-19
• Automatic offers:
• aimane-chnaif | Reviewer | 28066127
• sourcecodedeveloper | Contributor | 28066128

Issue Owner

Current Issue Owner: @aimane-chnaif

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01837f964a8d992695

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Desktop - Login - Magic code is sent twice or more after double tapping "Enter" button

What is the root cause of that problem?

We did not use useSingleExecution in BaseLoginForm

What changes do you think we should make in order to solve the problem?

wrap validateAndSubmitForm function in singleExecution

    const {isExecuting, singleExecution} = useSingleExecution();

onSubmit={singleExecution(validateAndSubmitForm)}
isDisabled={isExecuting}

...
onSubmitEditing={singleExecution(validateAndSubmitForm)}

[BhuvaneshPatil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Desktop - Login - Magic code is sent twice or more after double tapping "Enter" button

What is the root cause of that problem?

We have not used debouncing for validateAndSubmitForm function.

What changes do you think we should make in order to solve the problem?

We shall use debounce from lodash for this with time period of 1000ms (not final, can be changed) this way we can avoid calling it double if we press enter double and quick.

What alternative solutions did you explore? (Optional)

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Desktop - Login - Magic code is sent twice or more after double tapping "Enter" button

What is the root cause of that problem?

We don't have any disable function until navigate to verifyCodePage

What changes do you think we should make in order to solve the problem?

1. We need to cover validateAndSubmitForm with singleExecution

onSubmit={singleExecution(validateAndSubmitForm)}

onSubmitEditing={singleExecution(validateAndSubmitForm)}

2. we need to add one condition.

if (props.network.isOffline || props.account.isLoading || isExecuting) {

App/src/pages/signin/LoginForm/BaseLoginForm.js

Line 168 in 48b5a29

if (props.network.isOffline || props.account.isLoading) {

What alternative solutions did you explore? (Optional)

[ai-master-coder]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Login - Magic code is sent twice or more after double tapping "Enter" button

What is the root cause of that problem?

The root cause occurs when a user quickly presses the submit button two or three times. In React, when a component renders, all of its event handlers are recreated. This implies that if the user presses the submit button twice during a single render cycle, two separate validateAndSubmitForm functions will be created, each independently attempting the login.

What changes do you think we should make in order to solve the problem?

In the context of the BaseLoginForm component, the utilization of _.debounce proves beneficial in preventing multiple submissions of the form in rapid succession. The useCallback hook serves to memoize a function, ensuring that the same function instance is returned for each render cycle. This memoization strategy helps mitigate performance issues stemming from the unnecessary recreation of functions during each render.

Through the synergistic application of useDebounce and useCallback, we adeptly address performance concerns arising from both swift, consecutive events and the avoidance of superfluous function recreations.

In validateAndSubmitForm function used already useCallback function, so

In src/pages/signin/LoginForm/BaseLoginForm.js, change to -

<FormAlertWithSubmitButton
    ...
    onSubmit={_.debounce(validateAndSubmitForm,400)}
    ...
>

What alternative solutions did you explore? (Optional)