[HOLD for payment 2024-01-03] [$500] Distance - Save button is unresponsive when adding, saving, then removing new point offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.7-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR #31340

Action Performed:

1. Go to staging.new.expensify.com
2. Create a distance request
3. Open distance request details page
4. Click Distance
5. Go offline
6. Add a new stop and save it
7. Click Distance again
8. Remove the new stop added in Step 5
9. Click Save

Expected Result:

The new distance will be saved

Actual Result:

Nothing happens when clicking on Save button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6298236_1701490520825.20231202_023135.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e1d8e03c3ce30d53
• Upwork Job ID: 1730948270789206016
• Last Price Increase: 2023-12-09
• Automatic offers:
• dukenv0307 | Contributor | 28064597

Issue Owner

Current Issue Owner: @robertKozik

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e1d8e03c3ce30d53

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Save button is unresponsive when adding, saving, then removing new point offline

What is the root cause of that problem?

When we change the waypoint the first time, isLoading is set as true here.

App/src/libs/actions/IOU.js

Line 750 in 1682be4

isLoading: _.has(transactionChanges, 'waypoints'),

And we do nothing here if isLoading is true

App/src/components/DistanceRequest/index.js

Line 181 in 1682be4

if (_.size(validatedWaypoints) < 2 || hasRouteError || isLoadingRoute || isLoading) {

What changes do you think we should make in order to solve the problem?

We can allow saving waypoint if we are offline even isLoading is true

What alternative solutions did you explore? (Optional)

We can disable edit address and save waypoint if isLoading is true

[rakshitjain13]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance - Save button is unresponsive when adding, saving, then removing new point offline

What is the root cause of that problem?

On first request in offline mode like saving, deleting, or editing the request, we change isLoading to true here

App/src/libs/actions/IOU.js

Line 750 in 1682be4

isLoading: _.has(transactionChanges, 'waypoints'),

and on the next request

App/src/components/DistanceRequest/index.js

Line 181 in 1682be4

if (_.size(validatedWaypoints) < 2 || hasRouteError || isLoadingRoute || isLoading) {

we are unable to proceed because of above .

What changes do you think we should make in order to solve the problem?

We have to skip checking isLoading in offline mode

  if (_.size(validatedWaypoints) < 2 || hasRouteError || isLoadingRoute || (isLoading && !isOffline)) {
            setHasError(true);
            return;
        }

What alternative solutions did you explore? (Optional)

[melvin-bot]

📣 @VenusWhisperer! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>