[HOLD for payment 2023-12-20] [$500] Expense - System message for report submission is not copied when copied to clipboard

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.6.2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #32157

Action Performed:

Precondition:

• User is an employee of a Collect workspace

1. Log in to ND as the employee
2. Go to the workspace chat > + > Request money
3. Create a manual request
4. Click on the expense preview > Submit
5. Click on the header subtitle to return to workspace main chat
6. Click on the expense preview
7. Right click on the 'report submission' message > Copy to clipboard
8. Paste it in the composer

Expected Result:

The system message for 'report submission' is copied

Actual Result:

The system message for 'report submission' is not copied

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6296248_1701363447163.20231130_231808.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dc72215454974184
• Upwork Job ID: 1730286719439400960
• Last Price Increase: 2023-11-30
• Automatic offers:
• shubham1206agra | Reviewer | 27951200
• bernhardoj | Contributor | 27951201

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01dc72215454974184

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[bernhardoj]

Any way to get access to/part of Collect Workspace?

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - System message for report submission is not copied when copied to clipboard

What is the root cause of that problem?

We are not handling the REPORT.ACTIONS.TYPE.SUBMITTED report action case in ContextMenuActions copy to clipboard

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 263 to 264 in a7460f7

	onPress: (closePopover, {reportAction, selection}) => {
	const isTaskAction = ReportActionsUtils.isTaskAction(reportAction);

What changes do you think we should make in order to solve the problem?

We need to add another else if before last one here

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 287 in a7460f7

} else if (content) {

like

else if (reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.SUBMITTED) {
                    Clipboard.setString(lodashGet(reportAction, 'message', []).map(message => message.text).join(''));
                }

What alternative solutions did you explore? (Optional)

[shubham1206agra]

Just checked

@FitseTLT proposal works correctly. I think we should go with this.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.