[HOLD for payment 2023-12-26] [$500] Expense-In "recents",category selected while creating expense is displayed instead of altered.

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.5-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap employee WS chat
3. Tap plus icon near compose
4. Tap request money ----- Manual
5. Enter an amount
6. Tap next
7. Tap show more
8. Select a category
9. Tap request
10. Open newly created expense
11. Tap category and select a new category
12. Navigate back to employee Workspace chat
13. Tap plus icon near compose
14. Tap request money ----- Manual
15. Enter an amount
16. Tap next
17. Tap show more
18. Tap category
19. Note, the category selected while creating expense is displayed in "recents" on top
20. Refresh the page
21. Note, the category altered after expense created is displayed in "recents" now

Expected Result:

The category altered after expense created must be displayed in "recents" on top

Actual Result:

The category selected while creating expense is displayed in "recents" on top. The altered category is shown in "recents" only after refreshing the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6295123_1701290660925.refresh.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f8b6f650f2e88ed5
• Upwork Job ID: 1729985911471767552
• Last Price Increase: 2023-11-29
• Automatic offers:
• hoangzinh | Reviewer | 27916699
• DylanDylann | Contributor | 27916700

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f8b6f650f2e88ed5

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense-In "recents",category selected while creating expense is displayed instead of altered

What is the root cause of that problem?

Currently, we only update policyRecentlyUsedCategories when creating new request. We don't update policyRecentlyUsedCategories when editing a request

What changes do you think we should make in order to solve the problem?

We need to add logic to update policyRecentlyUsedCategories when editing category field
To do that in editDistanceMoneyRequest we should add this logic

let optimisticPolicyRecentlyUsedCategories = [];
if (_.has(transactionChanges, 'category')) {
        
        optimisticPolicyRecentlyUsedCategories = Policy.buildOptimisticPolicyRecentlyUsedCategories(iouReport.policyID, transactionChanges.category);

        if (!_.isEmpty(optimisticPolicyRecentlyUsedCategories)) {
            optimisticData.push({
                onyxMethod: Onyx.METHOD.SET,
                key: `${ONYXKEYS.COLLECTION.POLICY_RECENTLY_USED_CATEGORIES}${iouReport.policyID}`,
                value: optimisticPolicyRecentlyUsedCategories,
            });
        }
    }

Do the same thing to EditMoneyRequest Function

We can create new utils function to avoid duplicated code. This function will handle both updating recently used categories and recently used tags in both editDistanceMoneyRequest and EditMoneyRequest function

What alternative solutions did you explore? (Optional)

[hoangzinh]

@DylanDylann Thanks for your proposal #32230 (comment)

• Your RCA is correct. It's better if you can point out why the altered category is shown in "recents" only after refreshing the page.
• Your solution looks good to me. Moreover, you pointed our the same issue in creating a distance request. Look great.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @bondydaa, see https://stackoverflow.com/c/expensify/questions/7972 for more details.