[HOLD for payment 2023-12-28] [$500] Distance - Map, amount and distance in the background shows TBD when editing distance

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.4.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com
2. Go to a workspace chat with distance request.
3. Open distance request details page.
4. Click Distance.
5. Click Add stop.
6. Add a new address.

Expected Result:

The map, amount and distance in the background will not show TBD because user is editing the distance without saving.

Actual Result:

The map, amount and distance in the background shows TBD without saving.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6293218_1701178732509.20231128_134639.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c7d894fb538d33ef
• Upwork Job ID: 1729498349642403840
• Last Price Increase: 2023-12-12
• Automatic offers:
• ntdiary | Reviewer | 28055126
• DylanDylann | Contributor | 28055129

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c7d894fb538d33ef

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance - Map, amount and distance in the background shows TBD when editing distance

What is the root cause of that problem?

When selecting a new stop waypoint we will set pendingField.waypoint is updated and we only reset it to null if user click save button. We are displaying TBD in the amount field if there is a pending waypoint.

App/src/components/ReportActionItem/MoneyRequestView.js

Line 102 in 935608b

const hasPendingWaypoints = lodashGet(transaction, 'pendingFields.waypoints', null);

What changes do you think we should make in order to solve the problem?

We should update condition here

App/src/components/ReportActionItem/MoneyRequestView.js

Line 102 in 935608b

const hasPendingWaypoints = lodashGet(transaction, 'pendingFields.waypoints', null);

like that

    const hasPendingWaypointsAndOffline = lodashGet(transaction, 'pendingFields.waypoints', null) && isOffline;

And using it instead of hasPendingWaypoints in everywhere.

What alternative solutions did you explore? (Optional)

I am not sure why we need to set pendingField.waypoint when selecting a new waypoint

App/src/libs/actions/Transaction.ts

Line 61 in 935608b

pendingFields: {

Even though we don't call API in here. Normally, pendingField and pending action only be added in optimisticaData (apply before sending API) and It is re-set in successData and failureData
So I think we should not set pendingField.waypoint when the user updates a new waypoint, we only set the pending field if the user clicks save button

[shubham1206agra]

Proposal

Please re-state the problem that we are trying to solve in this issue

Distance - Map, amount and distance in the background shows TBD when editing distance

What is the root cause of that problem?

This is because we are editing directly on transaction Onyx. And we are using backup in transactionDraft_ collection for saving the last transaction.

Due to changes in transactions directly, the fields are getting TBD due to hasPendingWaypoints becomes true when adding waypoint.

What changes do you think we should make in order to solve the problem?

We can do the opposite. Use Transaction Draft for editing and then transfer the updated data on transaction collection later.

What alternative solutions did you explore? (Optional)

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When editing a Distance request, the distance and amount fields are set to "TBD" before the actual update happens.

What is the root cause of that problem?

We are not handling the loading state of the distance transaction properly.
On the MoneyRequestView page, we use:

App/src/components/ReportActionItem/MoneyRequestView.js

Line 102 in 12eb47f

const hasPendingWaypoints = lodashGet(transaction, 'pendingFields.waypoints', null);

Which equals true when we have modified the waypoints in the drawer, but have not saved them yet.

What changes do you think we should make in order to solve the problem?

We set the transaction.isLoading when modifying the waypoints of the distance request here:

App/src/libs/actions/IOU.js

Lines 757 to 766 in cd9cd57

	optimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`,
	value: {
	...updatedTransaction,
	pendingFields,
	isLoading: _.has(transactionChanges, 'waypoints'),
	errorFields: null,
	},
	});

And we handle this state in other places, like here:

App/src/components/DistanceRequest/index.js

Line 84 in 19c8e25

const isLoading = lodashGet(transaction, 'isLoading', false);

First, on MoneyRequestView, we should also replace the hasPendingWaypoints with isLoading along with isOffline, and use it in places where hasPendingWaypoints is currently used:

const isLoading = lodashGet(transaction, 'isLoading', false) && isOffline;

Second, we should also use if (!transaction.isLoading) instead of if (!Object.hasOwn(transaction?.pendingFields ?? {}, 'waypoints')) here, otherwise the map will be replaced with the pending receipt while the waypoints are being added.

App/src/libs/ReceiptUtils.ts

Line 40 in 61c8b11

if (!Object.hasOwn(transaction?.pendingFields ?? {}, 'waypoints')) {

Basically, we will need to modify most of the changes made in PR #30232 using this condition.

What alternative solutions did you explore? (Optional)