[HOLD for payment 2024-02-01] [HOLD for payment 2024-01-31] [$250] Chat-No unread marker when chat with the latest text is from you and marked as unread from LHN

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.2-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch New Expensify app
2. Mark a chat where the latest message is not from you, as unread
3. Open the chat
4. Note that it shows the unread marker
5. Send a few messages to the chat
6. Return to LHN
7. Long press on the chat and mark it as unread
8. Open the chat

Expected Result:

The unread marker will be displayed

Actual Result:

The unread marker is not displayed. This only happens when the latest message comes from the current app user

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6287687_1700684028156.RPReplay_Final1700671844.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c2b3a63cdf2318c4
• Upwork Job ID: 1727427415139188736
• Last Price Increase: 2024-01-24
• Automatic offers:
• mollfpr | Reviewer | 28032969
• dukenv0307 | Contributor | 28032971

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c2b3a63cdf2318c4

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[akamefi202]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No unread marker when chat with the latest text is from you and marked as unread from LHN.

What is the root cause of that problem?

App/src/pages/home/report/ReportActionsList.js

Lines 341 to 343 in 14abfa1

	if (!messageManuallyMarkedUnread) {
	shouldDisplay = shouldDisplay && reportAction.actorAccountID !== Report.getCurrentUserAccountID();
	}

Currently, shouldDisplayNewMarker function prevents showing unread marker if the sender of last message is the current app user.
As a result, we can't see unread marker if the current user sent the last message.

What changes do you think we should make in order to solve the problem?

We might delete this code part to show unread marker although the last messgae is sent by the current user.

What alternative solutions did you explore? (Optional)

N/A

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The unread marker is not displayed. This only happens when the latest message comes from the current app user

What is the root cause of that problem?

When we mark a message as unread from LHN, it will mark the last message as unread as in here. In case the logged in user is the one sending the last message, that message will be marked as unread, which is not correct because the it doesn't make sense for the user to "unread" their own message. So based on this condition, the marker will not be visible on user's own message.

In this case we should do the same as Slack does, which is to mark the "latest message that doesn't come from current user" as unread.

What changes do you think we should make in order to solve the problem?

In here, if reportActionCreated is not available, we should find the latest message that doesn't come from current user to get the actionCreationTime, and use that as the basis for marking the lastReadTime.

We might need BE change as well to follow the same logic.

What alternative solutions did you explore? (Optional)

If we want to fix the same way for marking unread from report action context menu, we need to pass the reportActionId to markCommentAsUnread and find the "latest report action doesn't come from current user" from that reportActionId backwards. This is also the same as how Slack does it.

Or we can disable Mark as unread in report action context menu for report actions that come from current user.

[melvin-bot]

@mollfpr, @miljakljajic Eep! 4 days overdue now. Issues have feelings too...