[$500] Web - Unable to move to the next input by using TAB button on keyboard

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.0.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @allroundexperts
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1700217396857389

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with any account
3. Go Setting - Profile - Personal details
4. Open the Legal name page
5. Use Tab key to move to the next input

Expected Result:

Able to move to the next input by using TAB button on keyboard

Actual Result:

Unable to move to the next input by using TAB button on keyboard

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2023-11-17.at.3.35.53.PM.mov

Recording.5453.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0196b1224492e0f053
• Upwork Job ID: 1725503766144282624
• Last Price Increase: 2023-11-24

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0196b1224492e0f053

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to move to the next input by using TAB button on keyboard

What is the root cause of that problem?

In GenericPressable here, we're not letting the passed in tabIndex (if exists) override the tabIndex.

So when we pass tabIndex={-1} to the pressable wrapping the Input in BaseTextInput to allow the tab navigation to go to the input, it doesn't work.

What changes do you think we should make in order to solve the problem?

In GenericPressable here, let the passed in tabIndex (if exists) override the tabIndex

const tabIndex = props.tabIndex ?? (!accessible || !focusable ? -1 : 0);

(Only added the props.tabIndex ??, so if the tabIndex exists, we'll use it)

What alternative solutions did you explore? (Optional)

NA

[dummy-1111]

Same root cause as #31203

[erquhart]

Not just same root cause, this one is a dupe. Just worded differently.

[erquhart]

Also this is a regression caused by #31118.