[HOLD for payment 2023-11-27] [$500] Chat - Keyboard is displayed on header menu screen after sending a file larger than 24 MB

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.0-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

Pre-requisite: user must be logged in.

1. Go to any chat.
2. Try to send a file larger than the 24 MB limit.
3. Close the "Attachment too large" modal.
4. Tap on the chat header.

Expected Result:

The header menu screen should be completely displayed without any issues.

Actual Result:

The keyboard is displayed on the screen.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6278652_1700113961015.Lsna2309_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014dbc5e01561f3f10
• Upwork Job ID: 1725093833215246336
• Last Price Increase: 2023-11-16
• Automatic offers:
• situchan | Contributor | 27705823

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014dbc5e01561f3f10

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[izarutskaya]

Not repro in prod

RPReplay_Final1700113029.MP4

[dukenv0307]

I'm available to raise a PR immediately if assigned

Proposal

Please re-state the problem that we are trying to solve in this issue.

The keyboard is displayed on the screen.

What is the root cause of that problem?

In here, we'll trigger onPopoverMenuClose when the screen lose focus, without checking if the popover menu is still visible at that time, causing the issue.

What changes do you think we should make in order to solve the problem?

Make sure the popover menu is currently visible first before calling onPopoverMenuClose. If it's not currently visible, we should not call onPopoverMenuClose because nothing is closing here.

useEffect(() => {
    if (!isMenuVisible || !didScreenBecomeInactive()) {
        return;
    }
    onPopoverMenuClose();
}, [didScreenBecomeInactive, onPopoverMenuClose, isMenuVisible]);

What alternative solutions did you explore? (Optional)

This will make the behavior when closing the attachment error modal to be the same as on prod. If instead we want to open the keyboard after closing the attachment error modal, we need to trigger restoreKeyboardState after that attachment error modal closes.

[situchan]

@dukenv0307 this is marked as deploy blocker. What is offending PR?