[HOLD for payment 2023-12-07] [$500] Address - Blue border appears around the row and the field is not focused when using Tab key

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.98-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com
2. Go to Settings > Profile > Personal details > Address
3. Click on any field
4. Navigate to the next field with tab key

Expected Result:

The next field will be focused with just one click

Actual Result:

A blue border appears around the field and the next field is not focused. It is only focused after pressing Tab key for the second time
This issue also happens in other area of the app that involve entering value

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6271705_1699645153642.20231111_002549.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e6211747d5d8420e
• Upwork Job ID: 1723065952129036288
• Last Price Increase: 2023-11-17
• Automatic offers:
• Ollyws | Reviewer | 27794733
• tienifr | Contributor | 27794734

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e6211747d5d8420e

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Blue border appears around the row and the field is not focused when using Tab key. This issue happens to all TextInput components.

What is the root cause of that problem?

The container wrapping text input is intentionally set with tabIndex=-1 to avoid navigating by tab to focus on itself.

App/src/components/TextInput/BaseTextInput/index.js

Line 258 in 3939bea

tabIndex={-1}

However inside WebGenericPressable, we do not pass tabIndex properly:

App/src/components/Pressable/GenericPressable/index.tsx

Line 16 in 3939bea

tabIndex={!accessible || !focusable ? -1 : 0}

Previously we used focusable to determine tabIndex. However, now focusable is replaced with tabIndex due to RNW upgrade. Therefore, if tabIndex is used, we should prioritize it and should not depend merely on focusable (deprecated) and accessible.

What changes do you think we should make in order to solve the problem?

Pass tabIndex like this:

tabIndex={props.tabIndex ?? (!accessible || !focusable ? -1 : 0)}

What alternative solutions did you explore? (Optional)

NA

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Blue border appears on the row when pressing tab key in the address page

What is the root cause of that problem?

To prevent focusing by tab, we set tabIndex=-1 below

App/src/components/TextInput/BaseTextInput/index.js

Line 258 in 3939bea

tabIndex={-1}

but tabIndex is changed here

App/src/components/Pressable/GenericPressable/index.tsx

Line 16 in 3939bea

tabIndex={!accessible || !focusable ? -1 : 0}

This is the root cause

What changes do you think we should make in order to solve the problem?

I think we need to use props.tabIndex if exists
Update

App/src/components/Pressable/GenericPressable/index.tsx

Line 16 in 3939bea

tabIndex={!accessible || !focusable ? -1 : 0}

to

            tabIndex={props.tabIndex ?? (!accessible || !focusable) ? -1 : 0}

This works as expected

What alternative solutions did you explore? (Optional)

[isabelastisser]

Hey @Ollyws, can you please review the proposals above? Thanks!