[$500] Room-Scrolled up members list scrolled down in admins account everytime message received

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.97-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Launch app
2. Tap on a room with many members
3. Tap on header
4. Tap members
5. Scroll up the page and note last contact
6. Go to https://staging.new.expensify.com/
   in other device
7. Login in as member who is shown in last in room members list while scrolled up
8. Tap on room
9. Send a message
10. Note - Admin room members list page scrolled down everytime user sends a message
11. Navigate back to Room and note new message received
12. Again tap header--Members
13. Scroll up the page
14. From members account, as mentioned in step 9 again send a message
15. Note - Admin room members list page now got scrolled down
16. Navigate back to room and verify new message received

Expected Result:

Scrolled up members list must not scrolled down in admins account when message is sent from invited user account.

Actual Result:

Scrolled up members list scrolled down in admins account everytime message is sent from invited user account.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6269768_1699525155057.last_user.mp4

Bug6269768_1699525081372.room_scrolled.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01198909fcc1f7f42d
• Upwork Job ID: 1722573758151155712
• Last Price Increase: 2024-03-28

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01198909fcc1f7f42d

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Scrolled up members list is scrolled down every time message received

What is the root cause of that problem?

When a message is received, RoomMembersPage is re-rendered, and the data is recalculated as you can see below

App/src/pages/RoomMembersPage.js

Line 243 in 9862a3e

const data = getMemberOptions();

When section data is changed, we set focus to the first item and scroll to it

App/src/components/SelectionList/BaseSelectionList.js

Lines 340 to 351 in 9862a3e

	useEffect(() => {
	// do not change focus on the first render, as it should focus on the selected item
	if (firstLayoutRef.current) {
	return;
	}
	// set the focus on the first item when the sections list is changed
	if (sections.length > 0) {
	updateAndScrollToFocusedIndex(0);
	}
	// eslint-disable-next-line react-hooks/exhaustive-deps
	}, [sections]);

This is the root cause

What changes do you think we should make in order to solve the problem?

As mentioned above, we set focus to the first item and scroll to it when section data is changed. This isn't an intended behavior. This was added to focus and scroll to the first item when search(PR #30438 for issue #29080)

This isn't correct. This fix causes the selection list focus and scroll to the first item every time section data changes. We only need to focus and scroll to the first item when sections data is changed by changing search value.

Update the dependency to [textInputValue] would fix this issue

    useEffect(() => {
        // do not change focus on the first render, as it should focus on the selected item
        if (firstLayoutRef.current) {
            return;
        }

        // set the focus on the first item when the sections list is changed
        if (sections.length > 0) {
            updateAndScrollToFocusedIndex(0);
        }
        // eslint-disable-next-line react-hooks/exhaustive-deps
    }, [textInputValue]);

Note: Of course, we can use React.memo and useMemo not to recalculate the sections data when unrelated data of report is changed, but this can't solve the issue. Focusing and scrolling happen even when you select/unselect the option in members list because sections data is needed to be recalculated in this case. I think the above solution is the best option

Result

31110.mp4

What alternative solutions did you explore? (Optional)

[abdulrahuman5196]

Hi, Will review again today, just back from weekend