[HOLD for payment 2023-11-30] [$500] IOU-Description is shown in preview in manual request while receipt is uploading.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.97-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap fab
3. Tap request money--- Manual
4. Enter an amount and tap next
5. Select a user
6. Tap on 3 dots and "add receipt"
7. Enter description
8. Tap request amount
9. Tap on IOU

Expected Result:

In IOU report, the description must not be shown in preview while receipt is uploading.

Actual Result:

In IOU report, the description is shown in preview in manual request while receipt is uploading.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6269654_1699516685834.des.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0136e412ae57e89702
• Upwork Job ID: 1722554040572862464
• Last Price Increase: 2023-11-09
• Automatic offers:
• DylanDylann | Contributor | 27670888

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0136e412ae57e89702

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU-Description is shown in preview in manual request while receipt is uploading

What is the root cause of that problem?

This is the currently logic

    const shouldShowDescription = !_.isEmpty(description) && !shouldShowMerchant;

we don't have logic to check if receipt is canning

What changes do you think we should make in order to solve the problem?

Should add a logic to check if receipt is canning we will hide description like this

    const shouldShowDescription = !_.isEmpty(description) && !shouldShowMerchant && !isScanning

What alternative solutions did you explore? (Optional)

We also consider to add isScanning condition to definition of shouldShowMerchant too

[PiyushChandra17]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU-Description is shown in preview in manual request while receipt is uploading

What is the root cause of that problem?

We are not checking for,

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 164 in 16e40c9

const isScanning = hasReceipt && TransactionUtils.isReceiptBeingScanned(props.transaction);

Here,

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 174 in 16e40c9

const shouldShowDescription = !_.isEmpty(description) && !shouldShowMerchant;

Perhaps this is the root cause

What changes do you think we should make in order to solve the problem?

First things first check for isScanning upfront,

const shouldShowDescription = !isScanning && !_.isEmpty(description) && !shouldShowMerchant;

What alternative solutions did you explore? (Optional)

NA

[allroundexperts]

Thanks for your proposal @PiyushChandra17. I wasn't able to find it very different from what @DylanDylann proposed earlier.

@DylanDylann's proposal looks good.

🎀 👀 🎀 C+ reviewed