[HOLD for payment 2023-11-29] [$500] Personal details - App crashed when tap on Home address page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.96.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch App
2. Tap on Settings > Profile > Personal details
3. Tap on address

Expected Result:

Address page should be open.

Actual Result:

App crashed when tapping on Home address page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6266745_1699322553840.RPReplay_Final1699320482.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010ad9a28a992c9851
• Upwork Job ID: 1721813829199605760
• Last Price Increase: 2023-11-07
• Automatic offers:
• GItGudRatio | Contributor | 27554474

Issue Owner

Current Issue Owner: @alexpensify

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[thienlnam]

Found the PR that caused the regression: #29742

#29742 (comment)

[GItGudRatio]

I'm available to fix this issue immediately
cc @thienlnam

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when tapping on Home address page

What is the root cause of that problem?

The root cause lies in this line:

App/src/pages/settings/Profile/PersonalDetails/AddressPage.js

Line 215 in 040c8a7

accessibilityLabel={translate('common.addressLine')}

Since this does not have the parameters, undefined is used when trying to destructure parameters, causing the fatal crash.

What changes do you think we should make in order to solve the problem?

TO fix this, we can change the line to accessibilityLabel={translate('common.addressLine', {lineNumber: 2})}

What alternative solutions did you explore? (Optional)

remove accessibilityLabel

[thienlnam]

Sounds great - looks like that fixes it. Will assign ya