[HOLD for payment 2024-02-07][$500] Page refresh causes manual request with a receipt to be stuck

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.95-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @abdel-h66
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1698081033316989

Action Performed:

1. Open a chat
2. Create a manual request thought the chat plus icon (not the FAB)
3. Enter an amount and Next
4. Click the three dots on the top, and attach a receipt
5. Refresh the page in this step
6. The page will go back to the first step, autofilled with the previous amount.
7. Click next

Expected Result:

We should be able to continue to the request information page

Actual Result:

The page is stuck and keeps coming back whenever Next is clicked

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.198.mp4

Expensify.bugs.mp4

Monosnap.screencast.Oct.23.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b422f44a99747ac7
• Upwork Job ID: 1720802592517115904
• Last Price Increase: 2023-12-21
• Automatic offers:
• DylanDylann | Contributor | 28067917

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b422f44a99747ac7

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Page refresh causes manual request with a receipt to be stuck

What is the root cause of that problem?

Firstly, Let's see this issue: #28347 (similar case with scan flow)

We discussed about this problem before with scan request. But we missed a case: the manual request by adding a receipt

Note that if we upload the receipt and back to the participant page and then reload, the same bug also happens. This bug is mentioned here

What changes do you think we should make in order to solve the problem?

In here

App/src/libs/IOUUtils.ts

Line 41 in e81ed8f

const onFailure = () => navigateToStartMoneyRequestStep(requestType, iouType, transactionID, reportID);

We should add a check if It is a manual request and the file is lost. The app will be on the confirmation page and the receipt thumbnail is removed

const onFailure = () => {
        console.log("onFailure: ", requestType)
        if (requestType === CONST.IOU.REQUEST_TYPE.MANUAL) {
            IOU.setMoneyRequestReceipt_temporaryForRefactor(transactionID, '', '');
            return 
        }
        navigateToStartMoneyRequestStep(requestType, iouType, transactionID, reportID)
    }

With the big refactor on the request flow, navigateToStartStepIfScanFileCannotBeRead also be used in the participant page so this change also fix the bug on the participant page

This is result

sol.mp4

What alternative solutions did you explore? (Optional)

In here

App/src/libs/IOUUtils.ts

Line 41 in e81ed8f

const onFailure = () => navigateToStartMoneyRequestStep(requestType, iouType, transactionID, reportID);

We should add a check if It is a manual request and the file is lost. The app will redirect to the uploading screen

const onFailure = () => {
        console.log("onFailure: ", requestType)
        if (requestType === CONST.IOU.REQUEST_TYPE.MANUAL) {
            Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute(iouType, transactionID, reportID, Navigation.getActiveRouteWithoutParams()));
            return 
        }
        navigateToStartMoneyRequestStep(requestType, iouType, transactionID, reportID)
    }

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After adding a receipt to the manual request, page refresh causes manual request to be stuck

What is the root cause of that problem?

When we adding a receipt to the manual request, we create blob URL and set it to the iou

App/src/pages/iou/ReceiptSelector/index.js

Lines 135 to 136 in 7bd51eb

	const filePath = URL.createObjectURL(file);
	IOU.setMoneyRequestReceipt(filePath, file.name);

App/src/pages/iou/ReceiptSelector/index.js

Lines 154 to 155 in 7bd51eb

	const filePath = URL.createObjectURL(imageFile);
	IOU.setMoneyRequestReceipt(filePath, imageFile.name);

But this object URL is only valid for the current session and will be revoked once the page is refreshed. So when navigating to the confirmation page, file would be null and it'll be redirected to the manual request page or previous page.

App/src/pages/iou/steps/MoneyRequestConfirmPage.js

Lines 106 to 109 in 7bd51eb

	FileUtils.readFileAsync(props.iou.receiptPath, props.iou.receiptFilename).then((file) => {
	if (!file) {
	Navigation.goBack(ROUTES.MONEY_REQUEST.getRoute(iouType, reportID));
	} else {

This is the root cause

What changes do you think we should make in order to solve the problem?

I don't think we need to go back to the manual request page when object URL is not valid.
I suggest to reset the receipt in this case

Update the above code to

        FileUtils.readFileAsync(props.iou.receiptPath, props.iou.receiptFilename).then((file) => {
            if (!file) {
                IOU.setMoneyRequestReceipt('', '');
            } else {

Result

30884.mp4

What alternative solutions did you explore? (Optional)

[DylanDylann]

@s-alves10 Your proposal is the same as my alternative solution 😄 (same interesting idea)

[abdel-h66]

I actually reported this one and worked on a solution that I shared on Slack. Not sure why @m-natarajan didn't include it :) could you double-check again please :), and please check the Reported GitHub ID. that's not me it should be @abdel-h66