[HOLD for payment 2024-01-09] [$500] Web - Chat- A different group chat appears when refreshing the page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.94.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jliexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1698904742009159

Action Performed:

1. Create a group conversation
2. Type something
3. Clicking on a profile
4. Refresh the page

Expected Result:

The same group chat appears when refreshing the page

Actual Result:

A different group chat appears when refreshing the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2023-11-02_16-57-00.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b7f90c720aa62a3c
• Upwork Job ID: 1720504021677768704
• Last Price Increase: 2023-11-03
• Automatic offers:
• shubham1206agra | Reviewer | 27782087
• DylanDylann | Contributor | 27782088

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b7f90c720aa62a3c

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A different group chat is opened when we refresh while we have opened profile detail of group chat member

What is the root cause of that problem?

When we open profile detail of a member of a group chat the route is changed to '.../a/memberID or ParticipantID' so the report id is lost from the url, hence when we refresh the last group chat reportId will be populated to ReportScreen via ReportIDSetter in the below code

App/src/libs/Navigation/AppNavigator/ReportScreenIDSetter.js

Lines 85 to 87 in 7b546b0

	// If there is no reportID in route, try to find last accessed and use it for setParams
	const reportID = getLastAccessedReportID(reports, !canUseDefaultRooms, policies, isFirstTimeNewExpensifyUser, lodashGet(route, 'params.openOnAdminRoom', false));

which sets the reportID to the id returned from ReportUtils.findLastAccessedReport which does not reliably return the id of last opened report by the user.

What changes do you think we should make in order to solve the problem?

We need to save a stack of latest opened report ids the user opened in onyx everytime a user opens a report. Then we will populate the latest available report id from the stack in the ReportScreenIDSetter changing this line of code

App/src/libs/Navigation/AppNavigator/ReportScreenIDSetter.js

Lines 85 to 87 in 7b546b0

	// If there is no reportID in route, try to find last accessed and use it for setParams
	const reportID = getLastAccessedReportID(reports, !canUseDefaultRooms, policies, isFirstTimeNewExpensifyUser, lodashGet(route, 'params.openOnAdminRoom', false));

to

        const lastOpendAvailableID = _.find(lastOpenedReportIDs, (reportID) => _.find(reports, (report) => report.reportID === reportID));
        // If there is no reportID in route, try to find last accessed and use it for setParams
        const reportID =
            lastOpendAvailableID || getLastAccessedReportID(reports, !canUseDefaultRooms, policies, isFirstTimeNewExpensifyUser, lodashGet(route, 'params.openOnAdminRoom', false));

after passing lastOpenedReportIDs prop via withOnyx here

export default withOnyx({
    lastOpenedReportIDs: {
        key: ONYXKEYS.LAST_OPENED_REPORT_IDS,
    },

So we will only fallback to the existing ReportUtils.findLastAccessedReport logic/code only in case when there is no available report id value saved in that new key ('LAST_OPENED_REPORT_IDS') we will create in onyx.
We can update the 'LAST_OPENED_REPORT_IDS' value on onyx in a useEffect on ReportScreen that runs when there is a change in reportID and save up to say 10 recent opened ids which will serve us to be a back up in case last opened report id doesn't exist or got deleted.

     
    useEffect(() => {
        if (!_.isEmpty(reportID)) {
            const updatedLastOpenedIDs = _.clone(lastOpenedReportIDs || []);

            // to limit the no of ids saved to 10
            if (updatedLastOpenedIDs.length === 10) updatedLastOpenedIDs.pop();
            updatedLastOpenedIDs.unshift(reportID);
            Onyx.merge(ONYXKEYS.LAST_OPENED_REPORT_IDS, updatedLastOpenedIDs);
        }
    }, [reportID]);

Moreover, we need to clear that value on onyx on signout so that a report ids saved for one user will not be used for another.

POC:

2023-11-03.23-07-08.mp4

What alternative solutions did you explore? (Optional)

or we can alternatively update the value in onyx every time the user navigates to a report.

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A different report is opened when we refresh while we have opened profile detail of group chat member

What is the root cause of that problem?

the profile page route doesnt contain any info about the reportId therefore the opened report in the background is not the same

What changes do you think we should make in order to solve the problem?

we need to modify the url of the profile page to contain the url of the report:
for example:
this way the screenwrapper will get the reportid and then displays it
/r/reportId/participants/:id/profile/

or we can add reportId as a param and modify the screener to look for this param and open it in the background

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Web - Chat- A different group chat appears when refreshing the page

What is the root cause of that problem?

• When launching the app with the deeplink that does not contain reportID, we use the getLastAccessedReportID to get the report to display.
  

  App/src/libs/Navigation/AppNavigator/ReportScreenIDSetter.js

  Lines 63 to 72 in 7bd51eb

  	const getLastAccessedReportID = (reports, ignoreDefaultRooms, policies, isFirstTimeNewExpensifyUser, openOnAdminRoom) => {
  	// If deeplink url contains reportID params, we should show the report that has this reportID.
  	const currentRoute = Navigation.getActiveRoute();
  	const {reportID} = ReportUtils.parseReportRouteParams(currentRoute);
  	if (reportID) {
  	return reportID;
  	}
  	const lastReport = ReportUtils.findLastAccessedReport(reports, ignoreDefaultRooms, policies, isFirstTimeNewExpensifyUser, openOnAdminRoom);
  	return lodashGet(lastReport, 'reportID');
  	};

• In the above, the findLastAccessedReport is not working properly.
  

  App/src/libs/ReportUtils.js

  Lines 575 to 581 in 7bd51eb

  	function findLastAccessedReport(reports, ignoreDomainRooms, policies, isFirstTimeNewExpensifyUser, openOnAdminRoom = false) {
  	// If it's the user's first time using New Expensify, then they could either have:
  	// - just a Concierge report, if so we'll return that
  	// - their Concierge report, and a separate report that must have deeplinked them to the app before they created their account.
  	// If it's the latter, we'll use the deeplinked report over the Concierge report,
  	// since the Concierge report would be incorrectly selected over the deep-linked report in the logic below.
  	let sortedReports = sortReportsByLastRead(reports);

• findLastAccessedReport uses sortReportsByLastRead:
  

  App/src/libs/ReportUtils.js

  Lines 263 to 269 in 7bd51eb

  	function sortReportsByLastRead(reports) {
  	return _.chain(reports)
  	.toArray()
  	.filter((report) => report && report.reportID && report.lastReadTime)
  	.sortBy('lastReadTime')
  	.value();
  	}

  that will sort the reports by "lastReadTime". This is incorrect because the "lastReadTime" refers to the latest time the user read a new message, not the latest time the user visits a report. For example, if we read a new message A on 3/10/2023, and re-visit its report on 4/10/2023, the "lastReadTime" is still '3/10/2023'.

What changes do you think we should make in order to solve the problem?

• Once we visit the report, we need to add the lastVisitTime: DateUtils.getDBTime() to the report or use ONYXKEYS.COLLECTION.REPORT_METADATA to store the above data.

• Then, in the sortReportsByLastRead, using lastVisitTime to sort the reports. We can do it by updating:
  

  App/src/libs/ReportUtils.js

  Lines 263 to 269 in 7bd51eb

  	function sortReportsByLastRead(reports) {
  	return _.chain(reports)
  	.toArray()
  	.filter((report) => report && report.reportID && report.lastReadTime)
  	.sortBy('lastReadTime')
  	.value();
  	}

  
  to:

function sortReportsByLastRead(reports) {
    return _.chain(reports)
+        .map((report) => {
+           const lastReadTime = lodashGet(report, 'lastVisitTime') || lodashGet(report, 'lastReadTime');
+             return {...report, lastReadTime};
        })
        .toArray()
        .filter((report) => report && report.reportID && report.lastReadTime)
        .sortBy('lastReadTime')
        .value();
}

What alternative solutions did you explore? (Optional)

• NA