[HOLD for payment 2024-02-07] [HOLD 30868][$1000] Drop user back to the last chat they were on when they leave a room.

[techievivek]

Problem:

Currently, if you leave a Room or Group you are dropped into your Concierge DM. The best reasoning for this is that you might have a support question or request. This is an assumption that, when weighed up against other options, feels less intuitive or useful.

Solution:

Drop users into whatever chat they were previously viewing before the viewed the room or group they left. Dropping a user into a chat they were just viewing is more likely to be useful than dropping a user into a Concierge DM.

E.g.:

1. Views #social
2. Views DM with Vit
3. Leaves DM with Vit
4. Drops into #social

On mobile, you should be dropped into the "chats screen".
Let me know if you have any questions or need clarification with anything, thanks.

This was reported here: https://expensify.slack.com/archives/C049HHMV9SM/p1697506231709359

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c9dae839c28297cd
• Upwork Job ID: 1720056216593899520
• Last Price Increase: 2023-11-06
• Automatic offers:
• getusha | Reviewer | 27580831
• eh2077 | Contributor | 27580835

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c9dae839c28297cd

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[techievivek]

This improvement was discussed here: https://expensify.slack.com/archives/C049HHMV9SM/p1697506231709359

[FitseTLT]

Proposal

I would like to work on it. According to the comment on the issue we need to change this lines of code to navigate the user to the last report using ReportUtils.findLastAccessedReport

App/src/libs/actions/Report.js

Lines 2074 to 2078 in 3db5ff4

	if (isWorkspaceMemberLeavingWorkspaceRoom) {
	const participantAccountIDs = PersonalDetailsUtils.getAccountIDsByLogins([CONST.EMAIL.CONCIERGE]);
	const chat = ReportUtils.getChatByParticipants(participantAccountIDs);
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(chat.reportID));
	}

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Drop user back to the last chat they were on when they leave a room

What is the root cause of that problem?

Actually when we leave room, we navigate to parent report if it's a thread, otherwise we will navigate to concierge chat

App/src/pages/home/ReportScreen.js

Lines 313 to 322 in 8ad8345

	Navigation.dismissModal();
	if (Navigation.getTopmostReportId() === prevOnyxReportID) {
	Navigation.setShouldPopAllStateOnUP();
	Navigation.goBack(ROUTES.HOME, false, true);
	}
	if (prevReport.parentReportID) {
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(prevReport.parentReportID));
	return;
	}
	Report.navigateToConciergeChat();

What changes do you think we should make in order to solve the problem?

We can store a value in Onyx like LAST_VIEWED_REPORT_ID. Whenever reportID from route is changed we will update this key if this reportID is valid.

And then when we leave the room we will goBack to the last report that is stored from this key. If the room is the first room we viewed we will calculate the last access reportID base on findLastAccessedReport with excluding this room.

App/src/pages/home/ReportScreen.js

Lines 313 to 322 in 8ad8345

	Navigation.dismissModal();
	if (Navigation.getTopmostReportId() === prevOnyxReportID) {
	Navigation.setShouldPopAllStateOnUP();
	Navigation.goBack(ROUTES.HOME, false, true);
	}
	if (prevReport.parentReportID) {
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(prevReport.parentReportID));
	return;
	}
	Report.navigateToConciergeChat();

I think we should also remove this logic here because we already have navigate logic when leaving room in ReportScreen

App/src/libs/actions/Report.js

Lines 2074 to 2077 in 3db5ff4

	if (isWorkspaceMemberLeavingWorkspaceRoom) {
	const participantAccountIDs = PersonalDetailsUtils.getAccountIDsByLogins([CONST.EMAIL.CONCIERGE]);
	const chat = ReportUtils.getChatByParticipants(participantAccountIDs);
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(chat.reportID));

What alternative solutions did you explore? (Optional)

[rayane-d]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We want to drop the user back to the last chat they were on when they leave a room, instead of droping them to Concierge chat.

What is the root cause of that problem?

We are navigating to concierge chat after leaving the room here:

App/src/libs/actions/Report.js

Lines 2074 to 2078 in c79529a

	if (isWorkspaceMemberLeavingWorkspaceRoom) {
	const participantAccountIDs = PersonalDetailsUtils.getAccountIDsByLogins([CONST.EMAIL.CONCIERGE]);
	const chat = ReportUtils.getChatByParticipants(participantAccountIDs);
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(chat.reportID));
	}

What changes do you think we should make in order to solve the problem?

we should implement a new function in ReportUtils called findPreviousAccessedReport. This function will determine the previous chat that the user was on

function findPreviousAccessedReport(reports) {
    let sortedReports = sortReportsByLastRead(reports);

    // Get the last report in the array, which is the current report.
    const currentReport = sortedReports[sortedReports.length - 1];

    // Find the index of the current report in the array.
    const currentIndex = sortedReports.indexOf(currentReport);

    if (currentIndex > 0) {
        // If the current report is not the first report in the array,
        // return the report before it as the previously accessed report.
        return sortedReports[currentIndex - 1];
    } else {
        // If the current report is the first report in the array,
        // there is no previously accessed report.
        return null;
    }
}

and the navigation logic should be updated as follows:

    if (isWorkspaceMemberLeavingWorkspaceRoom) {
        const previousReport = ReportUtils.findPreviousAccessedReport(allReports);
        if(previousReport){
             Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(previousReport.reportID));
        } else {
            const participantAccountIDs = PersonalDetailsUtils.getAccountIDsByLogins([CONST.EMAIL.CONCIERGE]);
            const chat = ReportUtils.getChatByParticipants(participantAccountIDs);  
            Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(chat.reportID));      
        }
    }

What alternative solutions did you explore? (Optional)

We can go back twice to get into the previous chat.

    if (isWorkspaceMemberLeavingWorkspaceRoom) {
        Navigation.goBack();
        Navigation.goBack();
    }

[orshikh-dev]

Contributor details
Your Expensify account email: orshikh.dev@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01477bce71bc1bc694

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!