[$500] Bank account - Extra padding between bank account selector and ToS checkbox

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.93-0
**Reproducible in staging?:**Y
Reproducible in production?: Cannot check bank account on production
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Settings > Workspaces > any workspace > Bank account > Connect with Plaid
3. Proceed with adding Chase bank account
4. Select a bank account in the selection page

Expected Result:

There is no extra padding between bank account selector and ToS checkbox in bank account selection page

Actual Result:

There is extra padding between bank account selector and ToS checkbox in bank account selection page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6256876_1698677897544.20231030_214057.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015f42c68e154b464f
• Upwork Job ID: 1719030382399614976
• Last Price Increase: 2023-10-30
• Automatic offers:
• ishpaul777 | Contributor | 27459210

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ishpaul777]

Proposal

Problem

Extra padding between bank account selector and ToS checkbox

Root cause

We have added margin Bottom at bankAccount selector here and also margin top here on CheckboxWithLabel resulting in extra gap between the components.

Changes

We can either remove margin bottom style from here or remove margin top here on CheckboxWithLabel..(depends on how much gap we need 20px or 16 px)

[francoisl]

Thanks for looking into this @ishpaul777. It doesn't seem like any of that code changed recently, this might not be a regression from a recent PR?

It's a minor style issue that doesn't break anything, I'm going to remove the deploy blocker label so we can treat this as a regular bug.